lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-12-24 17:51:17 +03:00
Code Activity

elf: Call __libc_early_init for reused namespaces (bug 29528)

Browse Source 
libc_map is never reset to NULL, neither during dlclose nor on a
dlopen call which reuses the namespace structure.  As a result, if a
namespace is reused, its libc is not initialized properly.  The most
visible result is a crash in the <ctype.h> functions.

To prevent similar bugs on namespace reuse from surfacing,
unconditionally initialize the chosen namespace to zero using memset.
This commit is contained in:
Florian Weimer
2022-08-26 21:15:43 +02:00
parent 06d4381dd8
commit d0e357ff45
5 changed files with 136 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
elf/dl-open.c
View File

@@ -844,11 +844,14 @@ _dl_open (const char *file, int mode, const void *caller_dlopen, Lmid_t nsid,
_dl_signal_error (EINVAL, file, NULL, N_("\
no more namespaces available for dlmopen()"));
}
else if (nsid == GL(dl_nns))
{
__rtld_lock_initialize (GL(dl_ns)[nsid]._ns_unique_sym_table.lock);
++GL(dl_nns);
}
if (nsid == GL(dl_nns))
++GL(dl_nns);
/* Initialize the new namespace. Most members are
zero-initialized, only the lock needs special treatment. */
memset (&GL(dl_ns)[nsid], 0, sizeof (GL(dl_ns)[nsid]));
__rtld_lock_initialize (GL(dl_ns)[nsid]._ns_unique_sym_table.lock);
_dl_debug_update (nsid)->r_state = RT_CONSISTENT;
}