lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

string: Add len=0 to {w}memcmp{eq} tests and benchtests

Browse Source 
len=0 is valid and fairly common so should be tested.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
This commit is contained in:
Noah Goldstein
2022-10-29 15:19:57 -05:00
parent 2e274cd8c1
commit ca7d181b62
2 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
string/test-memcmp.c
View File

@ -117,9 +117,6 @@ do_test (size_t align1, size_t align2, size_t len, int exp_result)
size_t i;
CHAR *s1, *s2;
if (len == 0)
return;
align1 &= (4096 - CHARBYTES);
if (align1 + (len + 1) * CHARBYTES >= page_size)
return;
@ -134,9 +131,16 @@ do_test (size_t align1, size_t align2, size_t len, int exp_result)
for (i = 0; i < len; i++)
s1[i] = s2[i] = 1 + (23 << ((CHARBYTES - 1) * 8)) * i % CHAR__MAX;
s1[len] = align1;
s2[len] = align2;
s2[len - 1] -= exp_result;
if (len)
{
s1[len] = align1;
s2[len] = align2;
s2[len - 1] -= exp_result;
}
else
{
exp_result = 0;
}
FOR_EACH_IMPL (impl, 0)
do_one_test (impl, s1, s2, len, exp_result);