lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

PowerPC: remove wrong roundl implementation for PowerPC64

Browse Source 
The roundl assembly implementation
(sysdeps/powerpc/powerpc64/fpu/s_roundl.S)
returns wrong results for some inputs where first double is a exact
integer and the precision is determined by second long double.

Checking on implementation comments and history, I am very confident the
assembly implementation was based on a version before commit
5c68d40169 that fixes BZ#2423 (Errors in
long double (ldbl-128ibm) rounding functions in glibc-2.4).

By just removing the implementation and make the build select
sysdeps/ieee754/ldbl-128ibm/s_roundl.c instead fixes the failing math.

This fixes 16707.
This commit is contained in:
Adhemerval Zanella
2014-03-14 12:49:45 -05:00
parent 98fb27a373
commit c7de502503
4 changed files with 17 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
math/libm-test.inc
View File

@ -10629,6 +10629,15 @@ static const struct test_f_f_data round_test_data[] =
TEST_f_f (round, -72057594037927936.75L, -72057594037927937.0L),
TEST_f_f (round, -72057594037927937.5L, -72057594037927938.0L),
/* Check cases where first double is a exact integer higher than 2^52 and
the precision is determined by second long double for IBM long double. */
TEST_f_f (round, 34503599627370498.515625L, 34503599627370499.0L),
TEST_f_f (round, -34503599627370498.515625L, -34503599627370499.0L),
# if LDBL_MANT_DIG >= 106
TEST_f_f (round, 1192568192774434123539907640624.484375L, 1192568192774434123539907640624.0L),
TEST_f_f (round, -1192568192774434123539907640624.484375L, -1192568192774434123539907640624.0L),
# endif
TEST_f_f (round, 10141204801825835211973625643007.5L, 10141204801825835211973625643008.0L),
TEST_f_f (round, 10141204801825835211973625643008.25L, 10141204801825835211973625643008.0L),
TEST_f_f (round, 10141204801825835211973625643008.5L, 10141204801825835211973625643009.0L),