lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

Add some spaces before '('.

Browse Source 
This patch fixes various places where a space should have been present
before '(' in accordance with the GNU Coding Standards.  Most but not
all of the fixes in this patch are for calls to sizeof (but it's not
exhaustive regarding such calls that should be fixed).

Tested for x86_64, and with build-many-glibcs.py.

	* benchtests/bench-strcpy.c (do_test): Use space before '('.
	* benchtests/bench-string.h (cmdline_process_function): Likewise.
	* benchtests/bench-strlen.c (do_test): Likewise.
	(test_main): Likewise.
	* catgets/gencat.c (read_old): Likewise.
	* elf/cache.c (load_aux_cache): Likewise.
	* iconvdata/bug-iconv8.c (do_test): Likewise.
	* math/test-tgmath-ret.c (do_test): Likewise.
	* nis/nis_call.c (rec_dirsearch): Likewise.
	* nis/nis_findserv.c (__nis_findfastest_with_timeout): Likewise.
	* nptl/tst-audit-threads.c (do_test): Likewise.
	* nptl/tst-cancel4-common.h (set_socket_buffer): Likewise.
	* nss/nss_test1.c (init): Likewise.
	* nss/test-netdb.c (test_hosts): Likewise.
	* posix/execvpe.c (maybe_script_execute): Likewise.
	* stdio-common/tst-fmemopen4.c (do_test): Likewise.
	* stdio-common/tst-printf.c (do_test): Likewise.
	* stdio-common/vfscanf-internal.c (__vfscanf_internal): Likewise.
	* stdlib/fmtmsg.c (NKEYWORDS): Likewise.
	* stdlib/qsort.c (STACK_SIZE): Likewise.
	* stdlib/test-canon.c (do_test): Likewise.
	* stdlib/tst-swapcontext1.c (do_test): Likewise.
	* string/memcmp.c (OPSIZ): Likewise.
	* string/test-strcpy.c (do_test): Likewise.
	(do_random_tests): Likewise.
	* string/test-strlen.c (do_test): Likewise.
	(test_main): Likewise.
	* string/test-strrchr.c (do_test): Likewise.
	(do_random_tests): Likewise.
	* string/tester.c (test_memrchr): Likewise.
	(test_memchr): Likewise.
	* sysdeps/generic/memcopy.h (OPSIZ): Likewise.
	* sysdeps/generic/unwind-dw2.c (execute_stack_op): Likewise.
	* sysdeps/generic/unwind-pe.h (read_sleb128): Likewise.
	(read_encoded_value_with_base): Likewise.
	* sysdeps/hppa/dl-machine.h (elf_machine_runtime_setup): Likewise.
	* sysdeps/hppa/fpu/feupdateenv.c (__feupdateenv): Likewise.
	* sysdeps/ia64/fpu/sfp-machine.h (TI_BITS): Likewise.
	* sysdeps/mach/hurd/spawni.c (__spawni): Likewise.
	* sysdeps/posix/spawni.c (maybe_script_execute): Likewise.
	* sysdeps/powerpc/fpu/tst-setcontext-fpscr.c (query_auxv):
	Likewise.
	* sysdeps/unix/sysv/linux/aarch64/bits/procfs.h (ELF_NGREG):
	Likewise.
	* sysdeps/unix/sysv/linux/arm/bits/procfs.h (ELF_NGREG): Likewise.
	* sysdeps/unix/sysv/linux/arm/ioperm.c (init_iosys): Likewise.
	* sysdeps/unix/sysv/linux/csky/bits/procfs.h (ELF_NGREG):
	Likewise.
	* sysdeps/unix/sysv/linux/m68k/bits/procfs.h (ELF_NGREG):
	Likewise.
	* sysdeps/unix/sysv/linux/nios2/bits/procfs.h (ELF_NGREG):
	Likewise.
	* sysdeps/unix/sysv/linux/spawni.c (maybe_script_execute):
	Likewise.
	* sysdeps/unix/sysv/linux/x86/bits/procfs.h (ELF_NGREG): Likewise.
	* sysdeps/unix/sysv/linux/x86/bits/sigcontext.h
	(FP_XSTATE_MAGIC2_SIZE): Likewise.
	* sysdeps/x86/fpu/sfp-machine.h (TI_BITS): Likewise.
	* time/test_time.c (main): Likewise.
This commit is contained in:
Joseph Myers
2019-02-27 13:55:45 +00:00
parent 457208b1e9
commit c4f50205e1
47 changed files with 138 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
string/memcmp.c
View File

@ -47,7 +47,7 @@
This should normally be the biggest type supported by a single load
and store. Must be an unsigned type. */
# define op_t unsigned long int
# define OPSIZ (sizeof(op_t))
# define OPSIZ (sizeof (op_t))
/* Threshold value for when to enter the unrolled loops. */
# define OP_T_THRES 16

8
string/test-strcpy.c
View File

@ -103,11 +103,11 @@ do_test (size_t align1, size_t align2, size_t len, int max_char)
but in wchar_ts, in bytes it will equal to align * (sizeof (wchar_t))
len for wcschr here isn't in bytes but it's number of wchar_t symbols. */
align1 &= 7;
if ((align1 + len) * sizeof(CHAR) >= page_size)
if ((align1 + len) * sizeof (CHAR) >= page_size)
return;
align2 &= 7;
if ((align2 + len) * sizeof(CHAR) >= page_size)
if ((align2 + len) * sizeof (CHAR) >= page_size)
return;
s1 = (CHAR *) (buf1) + align1;
@ -137,9 +137,9 @@ do_random_tests (void)
0 to 63 since some assembly implementations have separate
prolog for alignments more 48. */
align1 = random () & (63 / sizeof(CHAR));
align1 = random () & (63 / sizeof (CHAR));
if (random () & 1)
align2 = random () & (63 / sizeof(CHAR));
align2 = random () & (63 / sizeof (CHAR));
else
align2 = align1 + (random () & 24);
len = random () & 511;

12
string/test-strlen.c
View File

@ -80,7 +80,7 @@ do_test (size_t align, size_t len)
size_t i;
align &= 63;
if (align + sizeof(CHAR) * len >= page_size)
if (align + sizeof (CHAR) * len >= page_size)
return;
CHAR *buf = (CHAR *) (buf1);
@ -97,7 +97,7 @@ static void
do_random_tests (void)
{
size_t i, j, n, align, len;
CHAR *p = (CHAR *) (buf1 + page_size - 512 * sizeof(CHAR));
CHAR *p = (CHAR *) (buf1 + page_size - 512 * sizeof (CHAR));
for (n = 0; n < ITERATIONS; n++)
{
@ -148,16 +148,16 @@ test_main (void)
for (i = 1; i < 8; ++i)
{
do_test (sizeof(CHAR) * i, i);
do_test (sizeof (CHAR) * i, i);
do_test (0, i);
}
for (i = 2; i <= 12; ++i)
{
do_test (0, 1 << i);
do_test (sizeof(CHAR) * 7, 1 << i);
do_test (sizeof(CHAR) * i, 1 << i);
do_test (sizeof(CHAR) * i, (size_t)((1 << i) / 1.5));
do_test (sizeof (CHAR) * 7, 1 << i);
do_test (sizeof (CHAR) * i, 1 << i);
do_test (sizeof (CHAR) * i, (size_t)((1 << i) / 1.5));
}
do_random_tests ();

4
string/test-strrchr.c
View File

@ -86,7 +86,7 @@ do_test (size_t align, size_t pos, size_t len, int seek_char, int max_char)
CHAR *buf = (CHAR *) buf1;
align &= 7;
if ( (align + len) * sizeof(CHAR) >= page_size)
if ( (align + len) * sizeof (CHAR) >= page_size)
return;
for (i = 0; i < len; ++i)
@ -125,7 +125,7 @@ do_random_tests (void)
for (n = 0; n < ITERATIONS; n++)
{
align = random () & (63 / sizeof(CHAR));
align = random () & (63 / sizeof (CHAR));
/* For wcsrchr: align here means align not in bytes, but in wchar_ts,
in bytes it will equal to align * (sizeof (wchar_t)).
For strrchr we need to check all alignments from 0 to 63 since

12
string/tester.c
View File

@ -811,11 +811,11 @@ test_memrchr (void)
bugs due to unrolled loops (assuming unrolling is limited to no
more than 128 byte chunks: */
{
char buf[128 + sizeof(long)];
char buf[128 + sizeof (long)];
long align, len, i, pos, n = 9;
for (align = 0; align < (long) sizeof(long); ++align) {
for (len = 0; len < (long) (sizeof(buf) - align); ++len) {
for (align = 0; align < (long) sizeof (long); ++align) {
for (len = 0; len < (long) (sizeof (buf) - align); ++len) {
for (i = 0; i < len; ++i)
buf[align + i] = 'x'; /* don't depend on memset... */
@ -1230,11 +1230,11 @@ test_memchr (void)
bugs due to unrolled loops (assuming unrolling is limited to no
more than 128 byte chunks: */
{
char buf[128 + sizeof(long)];
char buf[128 + sizeof (long)];
long align, len, i, pos;
for (align = 0; align < (long) sizeof(long); ++align) {
for (len = 0; len < (long) (sizeof(buf) - align); ++len) {
for (align = 0; align < (long) sizeof (long); ++align) {
for (len = 0; len < (long) (sizeof (buf) - align); ++len) {
for (i = 0; i < len; ++i) {
buf[align + i] = 'x'; /* don't depend on memset... */
}