lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-28 00:21:52 +03:00
Code Activity

Move SNAN_TESTS_TYPE_CAST out of math-tests.h.

Browse Source 
The math-tests.h header has many different macros and groups of
macros, defined using #ifndef in the generic version which is included
by architecture versions with #include_next after possibly defining
non-default versions of some of those macros.

This use of #ifndef is contrary to our normal typo-proof conventions
for macro definitions.  This patch moves one of the macros,
SNAN_TESTS_TYPE_CAST, out to its own sysdeps header, to follow those
typo-proof conventions more closely.

Tested with build-many-glibcs.py.

2018-08-01  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/generic/math-tests-snan-cast.h: New file.
	* sysdeps/powerpc/math-tests-snan-cast.h: Likewise.
	* sysdeps/generic/math-tests.h: Include <math-tests-snan-cast.h>.
	(SNAN_TESTS_TYPE_CAST): Do not define macro here.
	* sysdeps/powerpc/math-tests.h (SNAN_TESTS_TYPE_CAST): Likewise.
This commit is contained in:
Joseph Myers
2018-08-01 11:18:57 +00:00
parent b029723b80
commit c0e7e2c127
5 changed files with 66 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sysdeps/generic/math-tests.h
View File

@ -52,12 +52,6 @@
/* Return nonzero value if to run tests involving sNaN values for X. */
#define SNAN_TESTS(x) MATH_TESTS_TG (SNAN_TESTS_, , x)
/* Indicate whether to run tests involving type casts of sNaN values. These
are run unless overridden. */
#ifndef SNAN_TESTS_TYPE_CAST
# define SNAN_TESTS_TYPE_CAST 1
#endif
/* Indicate whether operations on signaling NaNs preserve the payload
(if possible; it is not possible with a zero payload if the high
bit is set for signaling NaNs) when generating a quiet NaN, and
@ -122,3 +116,5 @@
#ifndef EXCEPTION_SET_FORCES_TRAP
# define EXCEPTION_SET_FORCES_TRAP 0
#endif
#include <math-tests-snan-cast.h>