lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-08-07 06:43:00 +03:00
Code Activity

Refactor internal-signals.h

Browse Source 
The main drive is to optimize the internal usage and required size
when sigset_t is embedded in other data structures.  On Linux, the
current supported signal set requires up to 8 bytes (16 on mips),
was lower than the user defined sigset_t (128 bytes).

A new internal type internal_sigset_t is added, along with the
functions to operate on it similar to the ones for sigset_t.  The
internal-signals.h is also refactored to remove unused functions

Besides small stack usage on some functions (posix_spawn, abort)
it lower the struct pthread by about 120 bytes (112 on mips).

Checked on x86_64-linux-gnu.

Reviewed-by: Arjun Shankar <arjun@redhat.com>
This commit is contained in:
Adhemerval Zanella
2022-04-21 09:41:59 -03:00
parent c22d2021a9
commit a1bdd81664
18 changed files with 184 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
nptl/pthread_kill.c
View File

@@ -45,8 +45,8 @@ __pthread_kill_implementation (pthread_t threadid, int signo, int no_tid)
}
/* Block all signals, as required by pd->exit_lock. */
sigset_t old_mask;
__libc_signal_block_all (&old_mask);
internal_sigset_t old_mask;
internal_signal_block_all (&old_mask);
__libc_lock_lock (pd->exit_lock);
int ret;
@@ -64,7 +64,7 @@ __pthread_kill_implementation (pthread_t threadid, int signo, int no_tid)
}
__libc_lock_unlock (pd->exit_lock);
__libc_signal_restore_set (&old_mask);
internal_signal_restore_set (&old_mask);
return ret;
}
@@ -83,7 +83,7 @@ __pthread_kill (pthread_t threadid, int signo)
{
/* Disallow sending the signal we use for cancellation, timers,
for the setxid implementation. */
if (__is_internal_signal (signo))
if (is_internal_signal (signo))
return EINVAL;
return __pthread_kill_internal (threadid, signo);
@@ -102,7 +102,7 @@ int
attribute_compat_text_section
__pthread_kill_esrch (pthread_t threadid, int signo)
{
if (__is_internal_signal (signo))
if (is_internal_signal (signo))
return EINVAL;
return __pthread_kill_implementation (threadid, signo, ESRCH);