lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-12-24 17:51:17 +03:00
Code Activity

Make x86_64 fegetenv preserve exception mask (bug 16198).

Browse Source 
Bug 16198 is x86_64 fegetenv wrongly masking exceptions for which
traps are enabled, because that's a side-effect of the fnstenv
instruction.  This patch fixes it to use fldenv immediately after
fnstenv, like the i386 version.  Tested x86_64 and x86.

	[BZ #16198]
	* sysdeps/x86_64/fpu/fegetenv.c (fegetenv): Use fldenv after
	fnstenv.
	* math/test-fenv-preserve.c: New file.
	* math/Makefile (tests): Add test-fenv-preserve.
This commit is contained in:
Joseph Myers
2014-03-26 18:59:08 +00:00
parent 60a2f3c166
commit 9be36fb8cb
5 changed files with 69 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
math/test-fenv-preserve.c Normal file
View File

@@ -0,0 +1,53 @@
/* Test fegetenv preserves exception mask (bug 16198).
Copyright (C) 2014 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
#include <fenv.h>
#include <stdio.h>
static int
do_test (void)
{
fenv_t env;
if (feenableexcept (FE_INVALID) != 0)
{
puts ("feenableexcept (FE_INVALID) failed, cannot test");
return 0;
}
if (fegetenv (&env) != 0)
{
puts ("fegetenv failed, cannot test");
return 0;
}
int ret = fegetexcept ();
if (ret == FE_INVALID)
{
puts ("fegetenv preserved exception mask, OK");
return 0;
}
else
{
printf ("fegetexcept returned %d, expected %d\n", ret, FE_INVALID);
return 1;
}
}
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"