1
0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-28 00:21:52 +03:00

Combine more conformtest tests into single execution of the compiler.

In <https://sourceware.org/ml/libc-alpha/2018-11/msg00225.html>,
Florian reported that the change from conformtest.pl to conformtest.py
had increased conform/ test time, possibly because of increased
startup overhead for Python scripts.

This patch improves conformtest.py performance by arranging for as
many tests of a (header, standard) pair as possible to use a single
execution of the compiler, so it does not need to initialize and parse
the whole header under test separately for every test assertion.
Specifically, compilation tests that are not marked as "optional" or
"xfail" are combined into a single source file, and are only then run
separately if compilation of that combined file fails.  For me, this
reduces the wall clock time for the conformtest.py tests (not the
whole of the conform/ directory) from two minutes to 15 seconds.

Tested for x86_64, and with build-many-glibcs.py.

	* conform/conformtest.py (CompileSubTest.__init__): Set
	self.run_early to False.
	(ExecuteSubTest.__init__): Likewise.
	(HeaderTests.run): Try running all non-optional, non-XFAILed
	compilation tests in a single execution of the compiler.
This commit is contained in:
Joseph Myers
2018-11-22 21:21:36 +00:00
parent cc6c89faf3
commit 95edd05c75
2 changed files with 29 additions and 1 deletions

View File

@ -1,5 +1,11 @@
2018-11-22 Joseph Myers <joseph@codesourcery.com> 2018-11-22 Joseph Myers <joseph@codesourcery.com>
* conform/conformtest.py (CompileSubTest.__init__): Set
self.run_early to False.
(ExecuteSubTest.__init__): Likewise.
(HeaderTests.run): Try running all non-optional, non-XFAILed
compilation tests in a single execution of the compiler.
* conform/conformtest.py (CompileSubTest): New class. * conform/conformtest.py (CompileSubTest): New class.
(ExecuteSubTest): Likewise. (ExecuteSubTest): Likewise.
(ElementTest.run): Rename to gen_subtests. Append tests to (ElementTest.run): Rename to gen_subtests. Append tests to

View File

@ -33,6 +33,7 @@ class CompileSubTest(object):
def __init__(self, name, text): def __init__(self, name, text):
"""Initialize a CompileSubTest object.""" """Initialize a CompileSubTest object."""
self.run_early = False
self.name = name self.name = name
self.text = text self.text = text
@ -46,6 +47,7 @@ class ExecuteSubTest(object):
def __init__(self, name, text): def __init__(self, name, text):
"""Initialize an ExecuteSubTest object.""" """Initialize an ExecuteSubTest object."""
self.run_early = False
self.name = name self.name = name
self.text = text self.text = text
@ -660,6 +662,21 @@ class HeaderTests(object):
available = self.compile_test('Availability of <%s>' % self.header, available = self.compile_test('Availability of <%s>' % self.header,
'') '')
if available: if available:
# As an optimization, try running all non-optional,
# non-XFAILed compilation tests in a single execution
# of the compiler.
combined_list = []
for test in self.tests:
if not test.optional and not test.xfail:
for subtest in test.subtests:
if isinstance(subtest, CompileSubTest):
combined_list.append(subtest.text)
subtest.run_early = True
combined_ok = self.compile_test('Combined <%s> test'
% self.header,
'\n'.join(combined_list))
# Now run the other tests, or all tests if the
# combined test failed.
for test in self.tests: for test in self.tests:
# A test may run more than one subtest. If the # A test may run more than one subtest. If the
# initial subtest for an optional symbol fails, # initial subtest for an optional symbol fails,
@ -673,7 +690,12 @@ class HeaderTests(object):
self.group_ignore = False self.group_ignore = False
self.group_skip = False self.group_skip = False
for subtest in test.subtests: for subtest in test.subtests:
subtest.run(self) if combined_ok and subtest.run_early:
self.total += 1
print('PASSCOMBINED: %s' % subtest.name)
sys.stdout.flush()
else:
subtest.run(self)
namespace_name = 'Namespace of <%s>' % self.header namespace_name = 'Namespace of <%s>' % self.header
if available: if available:
self.check_namespace(namespace_name) self.check_namespace(namespace_name)