lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

tunables: Use direct syscall for access (BZ#21744)

Browse Source 
The function maybe_enable_malloc_check, which is called by
__tunables_init, calls __access_noerrno.  It isn't problem when
symbol is is in ld.so, which has a special version of __access_noerrno
without stack protector.  But when glibc is built with stack protector,
maybe_enable_malloc_check in libc.a can't call the regular version of
__access_noerrno with stack protector.

This patch changes how Linux defines the __access_noerrno to be an
inline call instead and thus preventing defining different build
rules for ld/static and shared.

	H.J. Lu  <hongjiu.lu@intel.com>
	Adhemerval Zanella  <adhemerval.zanella@linaro.org>

	[BZ #21744]
	* elf/dl-tunables.c: Include not-errno.h header.
	* include/unistd.h (__access_noerrno): Remove definition.
	* sysdeps/unix/sysv/linux/access.c (__access_noerrno): Likewise.
	* sysdeps/generic/not-errno.h: New file.
	* sysdeps/unix/sysv/linux/not-errno.h: Likewise.
This commit is contained in:
Adhemerval Zanella
2017-07-17 18:11:12 -03:00
parent 422ff87c24
commit 95a7339258
6 changed files with 66 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
sysdeps/unix/sysv/linux/access.c
View File

@ -20,21 +20,6 @@
#include <unistd.h>
#include <sysdep-cancel.h>
int
__access_noerrno (const char *file, int type)
{
int res;
INTERNAL_SYSCALL_DECL (err);
#ifdef __NR_access
res = INTERNAL_SYSCALL_CALL (access, err, file, type);
#else
res = INTERNAL_SYSCALL_CALL (faccessat, err, AT_FDCWD, file, type);
#endif
if (INTERNAL_SYSCALL_ERROR_P (res, err))
return INTERNAL_SYSCALL_ERRNO (res, err);
return 0;
}
int
__access (const char *file, int type)
{