mirror of
https://sourceware.org/git/glibc.git
synced 2025-07-29 11:41:21 +03:00
stdio: Remove the usage of $(fno-unit-at-a-time) for errlist.c
The errlist.c is built with -fno-toplevel-reorder to avoid compiler to reorder the compat assembly directives due an assembler issue [1] (fixed on 2.39). This patch removes the compiler flags by split the compat symbol generation in two phases. First the _sys_errlist_internal internal without any compat symbol directive is preprocessed to generate an assembly source code. This generate assembly is then used as input on a platform agnostic errlist-data.S which then creates the compat definitions. This prevents compiler to move any compat directive prior the _sys_errlist_internal definition itself. Checked on a make check run-built-tests=no on all affected ABIs. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=29012
This commit is contained in:
@ -20,6 +20,7 @@
|
||||
#define _ERRLIST_COMPAT_H
|
||||
|
||||
#include <shlib-compat.h>
|
||||
#include <limits.h>
|
||||
|
||||
/* Define new compat symbols for symbols _sys_errlist, sys_errlist,
|
||||
_sys_nerr, and sys_nerr for version VERSION with NUMBERERR times number of
|
||||
@ -27,17 +28,25 @@
|
||||
Both _sys_errlist and sys_errlist alias to _sys_errlist_internal symbol
|
||||
(defined on errlist.c) while _sys_nerr and sys_nerr created new variable
|
||||
with the expected size. */
|
||||
#define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION) \
|
||||
const int __##VERSION##_sys_nerr = NUMBERERR; \
|
||||
strong_alias (__##VERSION##_sys_nerr, __##VERSION##__sys_nerr); \
|
||||
declare_symbol_alias (__ ## VERSION ## _sys_errlist, _sys_errlist_internal,\
|
||||
object, NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH)); \
|
||||
declare_symbol_alias (__ ## VERSION ## __sys_errlist, \
|
||||
_sys_errlist_internal, object, \
|
||||
NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH)); \
|
||||
compat_symbol (libc, __## VERSION ## _sys_nerr, sys_nerr, VERSION); \
|
||||
compat_symbol (libc, __## VERSION ## __sys_nerr, _sys_nerr, VERSION); \
|
||||
compat_symbol (libc, __## VERSION ## _sys_errlist, sys_errlist, VERSION); \
|
||||
compat_symbol (libc, __## VERSION ## __sys_errlist, _sys_errlist, VERSION);\
|
||||
#ifdef __ASSEMBLER__
|
||||
# define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION) \
|
||||
declare_object_symbol_alias (__ ## VERSION ## _sys_errlist, \
|
||||
_sys_errlist_internal, \
|
||||
NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH)) \
|
||||
ASM_LINE_SEP \
|
||||
declare_object_symbol_alias (__ ## VERSION ## __sys_errlist, \
|
||||
_sys_errlist_internal, \
|
||||
NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH)) \
|
||||
ASM_LINE_SEP \
|
||||
compat_symbol (libc, __## VERSION ## _sys_errlist, sys_errlist, VERSION) \
|
||||
ASM_LINE_SEP \
|
||||
compat_symbol (libc, __## VERSION ## __sys_errlist, _sys_errlist, VERSION)
|
||||
#else
|
||||
# define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION) \
|
||||
const int __##VERSION##_sys_nerr = NUMBERERR; \
|
||||
strong_alias (__##VERSION##_sys_nerr, __##VERSION##__sys_nerr); \
|
||||
compat_symbol (libc, __## VERSION ## _sys_nerr, sys_nerr, VERSION); \
|
||||
compat_symbol (libc, __## VERSION ## __sys_nerr, _sys_nerr, VERSION);
|
||||
#endif
|
||||
|
||||
#endif
|
||||
|
Reference in New Issue
Block a user