lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-08-05 19:35:52 +03:00
Code Activity

Fix SPARC64 handling of R_SPARC_H34 (bug 24231).

Browse Source 
Building glibc with -Wextra shows a -Wimplicit-fallthrough warning for
SPARC64 that appears to be a real bug in glibc.  The dynamic linker
handling of R_SPARC_H34 falls through to that of R_SPARC_H44, which in
the case of this code is nonsensical (it means the value computed for
R_SPARC_H34 gets overwritten by one computed with the different logic
for R_SPARC_H44).  Thus, this patch adds the missing break there.
Note: I do not have a testcase to demonstrate this bug.

Tested with build-many-glibcs.py.

	[BZ #24231]
	* sysdeps/sparc/sparc64/dl-machine.h (elf_machine_rela): Add break
	after R_SPARC_H34 case.
This commit is contained in:
Joseph Myers
2019-02-18 22:33:29 +00:00
parent 308e022fc4
commit 8c9289b642
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@@ -1,3 +1,9 @@
2019-02-18 Joseph Myers <joseph@codesourcery.com>
[BZ #24231]
* sysdeps/sparc/sparc64/dl-machine.h (elf_machine_rela): Add break
after R_SPARC_H34 case.
2019-02-18 Florian Weimer <fweimer@redhat.com> 2019-02-18 Florian Weimer <fweimer@redhat.com>
* resolv/compat-gethnamaddr.c (Dprintf): Remove definition. * resolv/compat-gethnamaddr.c (Dprintf): Remove definition.

1
sysdeps/sparc/sparc64/dl-machine.h
View File

@@ -573,6 +573,7 @@ elf_machine_rela (struct link_map *map, const Elf64_Rela *reloc,
*(unsigned int *) reloc_addr = *(unsigned int *) reloc_addr =
((*(unsigned int *)reloc_addr & 0xffc00000) | ((*(unsigned int *)reloc_addr & 0xffc00000) |
((value >> 12) & 0x3fffff)); ((value >> 12) & 0x3fffff));
break;
/* MEDMID code model relocs */ /* MEDMID code model relocs */
case R_SPARC_H44: case R_SPARC_H44: