lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

Optimize scripts/merge-test-results.sh

Browse Source 
The inner loop is called thousands of times per "make check" even
if there's otherwise nothing to do.  Avoid calling /bin/head all
those times when a builtin will do.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
This commit is contained in:
DJ Delorie
2020-04-01 15:33:00 -04:00
parent 19302b27bd
commit 78e09591a5
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scripts/merge-test-results.sh
View File

@ -35,7 +35,12 @@ case $type in
subdir=${subdir:+$subdir/} subdir=${subdir:+$subdir/}
for t in "$@"; do for t in "$@"; do
if [ -s "$objpfx$t.test-result" ]; then if [ -s "$objpfx$t.test-result" ]; then
head -n1 "$objpfx$t.test-result" # This loop is called thousands of times even when there's
# nothing to do. Avoid using non-built-in commands (like
# /bin/head) where possible. We assume "echo" is typically a
# built-in.
IFS= read -r line < "$objpfx$t.test-result"
echo "$line"
else else
echo "UNRESOLVED: $subdir$t" echo "UNRESOLVED: $subdir$t"
fi fi