lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

linux: use __fd_to_filename helper function instead of snprintf.

Browse Source 
Change made to fchmodat and fexecve. There are tests using xasprintf
instead of this helper as well, but this commit doesn't touch them.
This commit is contained in:
Érico Nogueira
2021-04-27 10:09:45 -03:00
committed by Adhemerval Zanella
parent 19d83270fc
commit 77c1573dbc
2 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
sysdeps/unix/sysv/linux/fchmodat.c
View File

@ -18,6 +18,7 @@
#include <errno.h>
#include <fcntl.h>
#include <fd_to_filename.h>
#include <not-cancel.h>
#include <stdio.h>
#include <sys/stat.h>
@ -69,16 +70,8 @@ fchmodat (int fd, const char *file, mode_t mode, int flag)
/* For most file systems, fchmod does not operate on O_PATH
descriptors, so go through /proc. */
char buf[32];
if (__snprintf (buf, sizeof (buf), "/proc/self/fd/%d", pathfd) < 0)
{
/* This also may report strange error codes to the caller
(although snprintf really should not fail). */
__close_nocancel (pathfd);
return -1;
}
int ret = __chmod (buf, mode);
struct fd_to_filename filename;
int ret = __chmod (__fd_to_filename (pathfd, &filename), mode);
if (ret != 0)
{
if (errno == ENOENT)