mirror of
https://sourceware.org/git/glibc.git
synced 2025-12-24 17:51:17 +03:00
Fix ldconfig segmentation fault with corrupted cache (Bug 18093).
ldconfig is using an aux-cache to speed up the ld.so.cache update. It is read by mmaping the file to a structure which contains data offsets used as pointers. As they are not checked, it is not hard to get ldconfig to segfault with a corrupted file. This happens for instance if the file is truncated, which is common following a filesystem check following a system crash. This can be reproduced for example by truncating the file to roughly half of it's size. There is already some code in elf/cache.c (load_aux_cache) to check for a corrupted aux cache, but it happens to be broken and not enough. The test (aux_cache->nlibs >= aux_cache_size) compares the number of libs entry with the cache size. It's a non sense, as it basically assumes that each library entry is a 1 byte... Instead this commit computes the theoretical cache size using the headers and compares it to the real size.
This commit is contained in:
committed by
Carlos O'Donell
parent
a2d4cf72c0
commit
6a1cf708dd
@@ -698,7 +698,9 @@ load_aux_cache (const char *aux_cache_name)
|
||||
if (aux_cache == MAP_FAILED
|
||||
|| aux_cache_size < sizeof (struct aux_cache_file)
|
||||
|| memcmp (aux_cache->magic, AUX_CACHEMAGIC, sizeof AUX_CACHEMAGIC - 1)
|
||||
|| aux_cache->nlibs >= aux_cache_size)
|
||||
|| aux_cache_size != (sizeof(struct aux_cache_file) +
|
||||
aux_cache->nlibs * sizeof(struct aux_cache_file_entry) +
|
||||
aux_cache->len_strings))
|
||||
{
|
||||
close (fd);
|
||||
init_aux_cache ();
|
||||
|
||||
Reference in New Issue
Block a user