mirror of
https://sourceware.org/git/glibc.git
synced 2025-08-08 17:42:12 +03:00
Harden putpwent, putgrent, putspent, putspent against injection [BZ #18724]
This prevents injection of ':' and '\n' into output functions which use the NSS files database syntax. Critical fields (user/group names and file system paths) are checked strictly. For backwards compatibility, the GECOS field is rewritten instead. The getent program is adjusted to use the put*ent functions in libc, instead of local copies. This changes the behavior of getent if user names start with '-' or '+'.
This commit is contained in:
31
nss/valid_field.c
Normal file
31
nss/valid_field.c
Normal file
@@ -0,0 +1,31 @@
|
||||
/* Copyright (C) 2015 Free Software Foundation, Inc.
|
||||
This file is part of the GNU C Library.
|
||||
|
||||
The GNU C Library is free software; you can redistribute it and/or
|
||||
modify it under the terms of the GNU Lesser General Public
|
||||
License as published by the Free Software Foundation; either
|
||||
version 2.1 of the License, or (at your option) any later version.
|
||||
|
||||
The GNU C Library is distributed in the hope that it will be useful,
|
||||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
Lesser General Public License for more details.
|
||||
|
||||
You should have received a copy of the GNU Lesser General Public
|
||||
License along with the GNU C Library; if not, see
|
||||
<http://www.gnu.org/licenses/>. */
|
||||
|
||||
#include <nss.h>
|
||||
#include <string.h>
|
||||
|
||||
const char __nss_invalid_field_characters[] = NSS_INVALID_FIELD_CHARACTERS;
|
||||
|
||||
/* Check that VALUE is either NULL or a NUL-terminated string which
|
||||
does not contain characters not permitted in NSS database
|
||||
fields. */
|
||||
_Bool
|
||||
__nss_valid_field (const char *value)
|
||||
{
|
||||
return value == NULL
|
||||
|| strpbrk (value, __nss_invalid_field_characters) == NULL;
|
||||
}
|
Reference in New Issue
Block a user