lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-30 22:43:12 +03:00
Code Activity

tunables: Simplify TUNABLE_SET interface

Browse Source 
The TUNABLE_SET interface took a primitive C type argument, which
resulted in inconsistent type conversions internally due to incorrect
dereferencing of types, especialy on 32-bit architectures.  This
change simplifies the TUNABLE setting logic along with the interfaces.

Now all numeric tunable values are stored as signed numbers in
tunable_num_t, which is intmax_t.  All calls to set tunables cast the
input value to its primitive type and then to tunable_num_t for
storage.  This relies on gcc-specific (although I suspect other
compilers woul also do the same) unsigned to signed integer conversion
semantics, i.e. the bit pattern is conserved.  The reverse conversion
is guaranteed by the standard.
This commit is contained in:
Siddhesh Poyarekar
2021-02-05 13:18:58 +05:30
parent e604a5e4bb
commit 61117bfa1b
6 changed files with 76 additions and 128 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
elf/dl-tunable-types.h
View File

@ -38,8 +38,8 @@ typedef enum
typedef struct
{
tunable_type_code_t type_code;
int64_t min;
int64_t max;
tunable_num_t min;
tunable_num_t max;
} tunable_type_t;
/* Security level for tunables. This decides what to do with individual