lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-30 22:43:12 +03:00
Code Activity

malloc: Check for integer overflow in valloc.

Browse Source 
A large bytes parameter to valloc could cause an integer overflow
and corrupt allocator internals. Check the overflow does not occur
before continuing with the allocation.

ChangeLog:

2013-09-11  Will Newton  <will.newton@linaro.org>

	[BZ #15856]
	* malloc/malloc.c (__libc_valloc): Check the value of bytes
	does not overflow.
This commit is contained in:
Will Newton
2013-08-16 11:59:37 +01:00
parent 1159a19369
commit 55e17aadc1
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2013-09-11 Will Newton <will.newton@linaro.org>
[BZ #15856]
* malloc/malloc.c (__libc_valloc): Check the value of bytes
does not overflow.
2013-09-11 Will Newton <will.newton@linaro.org> 2013-09-11 Will Newton <will.newton@linaro.org>
[BZ #15855] [BZ #15855]

7
malloc/malloc.c
View File

@ -3046,6 +3046,13 @@ __libc_valloc(size_t bytes)
size_t pagesz = GLRO(dl_pagesize); size_t pagesz = GLRO(dl_pagesize);
/* Check for overflow. */
if (bytes > SIZE_MAX - pagesz - MINSIZE)
{
__set_errno (ENOMEM);
return 0;
}
void *(*hook) (size_t, size_t, const void *) = void *(*hook) (size_t, size_t, const void *) =
force_reg (__memalign_hook); force_reg (__memalign_hook);
if (__builtin_expect (hook != NULL, 0)) if (__builtin_expect (hook != NULL, 0))