math: Remove the SVID error handling from atanhf

It improves latency for about 1-10% and throughput for about 5-10%. Tested on x86_64-linux-gnu and i686-linux-gnu. Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
2025-11-15 15:21:18 +03:00 · 2025-10-08 10:55:14 -03:00
parent 8facb464b4
commit 555c39c0fc
29 changed files with 52 additions and 4 deletions
--- a/math/Versions
+++ b/math/Versions
@@ -691,6 +691,7 @@ libm {
    acosf;
    acoshf;
    asinf;
+    atanhf;
    log10f;
  }
 }
--- a/math/w_atanhf_compat.c
+++ b/math/w_atanhf_compat.c
@@ -21,10 +21,10 @@
 #include <libm-alias-float.h>


-#if LIBM_SVID_COMPAT
+#if LIBM_SVID_COMPAT && SHLIB_COMPAT (libm, GLIBC_2_0, GLIBC_2_43)
 /* wrapper atanhf */
 float
-__atanhf (float x)
+__atanh_compatf (float x)
 {
  if (__builtin_expect (isgreaterequal (fabsf (x), 1.0f), 0)
      && _LIB_VERSION != _IEEE_)
@@ -35,5 +35,10 @@ __atanhf (float x)

  return __ieee754_atanhf (x);
 }
-libm_alias_float (__atanh, atanh)
+# ifdef NO_COMPAT_NEEDED
+strong_alias (__atanh_compatf, __atanhf)
+libm_alias_float (__atanh_compat, atanh)
+# else
+compat_symbol (libm, __atanh_compatf, atanhf, GLIBC_2_0);
+# endif
 #endif
--- a/sysdeps/ieee754/flt-32/e_atanhf.c
+++ b/sysdeps/ieee754/flt-32/e_atanhf.c
@@ -27,6 +27,8 @@ SOFTWARE.
 #include <math.h>
 #include <stdint.h>
 #include <libm-alias-finite.h>
+#include <libm-alias-float.h>
+#include <math-svid-compat.h>
 #include "math_config.h"

 static __attribute__((noinline)) float
@@ -42,7 +44,7 @@ as_special (float x)
 }

 float
-__ieee754_atanhf (float x)
+__atanhf (float x)
 {
  /* Calculate atanh(x) using the difference of two logarithms -- atanh(x) =
     (ln(1+x) - ln(1-x))/2  */
@@ -175,4 +177,11 @@ __ieee754_atanhf (float x)
    }
  return ub;
 }
+strong_alias (__atanhf, __ieee754_atanhf)
+#if LIBM_SVID_COMPAT
+versioned_symbol (libm, __atanhf, atanhf, GLIBC_2_43);
+libm_alias_float_other (__atanh, atanh)
+#else
+libm_alias_float (__atanh, atanh)
+#endif
 libm_alias_finite (__ieee754_atanhf, __atanhf)
--- a/sysdeps/ieee754/flt-32/w_atanhf.c
+++ b/sysdeps/ieee754/flt-32/w_atanhf.c
@@ -0,0 +1 @@
+/* Not needed.  */
--- a/sysdeps/m68k/m680x0/fpu/w_atanhf_compat.c
+++ b/sysdeps/m68k/m680x0/fpu/w_atanhf_compat.c
@@ -0,0 +1,8 @@
+/* m68k provides an optimized __ieee754_atanhf.  */
+#ifdef SHARED
+# define NO_COMPAT_NEEDED 1
+# include <math/w_atanhf_compat.c>
+#else
+# include <math-type-macros-float.h>
+# include <w_atanh_template.c>
+#endif
--- a/sysdeps/mach/hurd/i386/libm.abilist
+++ b/sysdeps/mach/hurd/i386/libm.abilist
@@ -1320,6 +1320,7 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 fmod F
 GLIBC_2.43 fmodf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/aarch64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/aarch64/libm.abilist
@@ -1288,4 +1288,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/alpha/libm.abilist
+++ b/sysdeps/unix/sysv/linux/alpha/libm.abilist
@@ -1447,4 +1447,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/arm/be/libm.abilist
+++ b/sysdeps/unix/sysv/linux/arm/be/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/arm/le/libm.abilist
+++ b/sysdeps/unix/sysv/linux/arm/le/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/hppa/libm.abilist
+++ b/sysdeps/unix/sysv/linux/hppa/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/i386/libm.abilist
+++ b/sysdeps/unix/sysv/linux/i386/libm.abilist
@@ -1327,6 +1327,7 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 fmod F
 GLIBC_2.43 fmodf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist
+++ b/sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/microblaze/be/libm.abilist
+++ b/sysdeps/unix/sysv/linux/microblaze/be/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/microblaze/le/libm.abilist
+++ b/sysdeps/unix/sysv/linux/microblaze/le/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/mips/mips32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/mips/mips32/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/mips/mips64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/mips/mips64/libm.abilist
@@ -1288,4 +1288,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist
@@ -1100,4 +1100,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist
@@ -1099,4 +1099,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libm.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libm.abilist
@@ -1093,4 +1093,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libm.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libm.abilist
@@ -1477,4 +1477,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist
@@ -1391,4 +1391,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist
@@ -1391,4 +1391,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/sh/be/libm.abilist
+++ b/sysdeps/unix/sysv/linux/sh/be/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/sh/le/libm.abilist
+++ b/sysdeps/unix/sysv/linux/sh/le/libm.abilist
@@ -953,4 +953,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist
@@ -1398,4 +1398,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist
@@ -1288,4 +1288,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/x86_64/64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/x86_64/64/libm.abilist
@@ -1321,4 +1321,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F
--- a/sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist
@@ -1321,4 +1321,5 @@ GLIBC_2.42 rsqrtl F
 GLIBC_2.43 acosf F
 GLIBC_2.43 acoshf F
 GLIBC_2.43 asinf F
+GLIBC_2.43 atanhf F
 GLIBC_2.43 log10f F