lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

nptl: Move part of TCB initialization from libpthread to __tls_init_tp

Browse Source 
This initalization should only happen once for the main thread's TCB.
At present, auditors can achieve this by not linking against
libpthread.  If libpthread becomes part of libc, doing this
initialization in libc would happen for every audit namespace,
or too late (if it happens from the main libc only).  That's why
moving this code into ld.so seems the right thing to do, right after
the TCB initialization.

For !__ASSUME_SET_ROBUST_LIST ports, this also moves the symbol
__set_robust_list_avail into ld.so, as __nptl_set_robust_list_avail.
It also turned into a proper boolean flag.

Inline the __pthread_initialize_pids function because it seems no
longer useful as a separate function.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
This commit is contained in:
Florian Weimer
2021-04-21 19:49:51 +02:00
parent 90d7e7e5bd
commit 442e8a40da
8 changed files with 52 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nptl/pthread_create.c
View File

@ -297,7 +297,7 @@ START_THREAD_DEFN
__ctype_init ();
#ifndef __ASSUME_SET_ROBUST_LIST
if (__set_robust_list_avail >= 0)
if (__nptl_set_robust_list_avail)
#endif
{
/* This call should never fail because the initial call in init.c
@ -447,7 +447,7 @@ START_THREAD_DEFN
/* We let the kernel do the notification if it is able to do so.
If we have to do it here there for sure are no PI mutexes involved
since the kernel support for them is even more recent. */
if (__set_robust_list_avail < 0
if (!__nptl_set_robust_list_avail
&& __builtin_expect (robust != (void *) &pd->robust_head, 0))
{
do