lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-28 00:21:52 +03:00
Code Activity

Replace rawmemchr (s, '\0') with strchr

Browse Source 
Almost all uses of rawmemchr find the end of a string.  Since most targets use
a generic implementation, replacing it with strchr is better since that is
optimized by compilers into strlen (s) + s.  Also fix the generic rawmemchr
implementation to use a cast to unsigned char in the if statement.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
This commit is contained in:
Wilco Dijkstra
2023-02-03 12:01:33 +00:00
parent d2d3f3720c
commit 32c7acd464
24 changed files with 34 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
string/rawmemchr.c
View File

@ -39,7 +39,7 @@ DIAG_IGNORE_NEEDS_COMMENT (11, "-Wstringop-overread");
void *
RAWMEMCHR (const void *s, int c)
{
if (c != '\0')
if ((unsigned char) c != '\0')
return memchr (s, c, (size_t)-1);
return (char *)s + strlen (s);
}