lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-29 11:41:21 +03:00
Code Activity

CVE-2016-3075: Stack overflow in _nss_dns_getnetbyname_r [BZ #19879]

Browse Source 
The defensive copy is not needed because the name may not alias the
output buffer.
This commit is contained in:
Florian Weimer
2016-03-29 12:57:56 +02:00
parent a6033052d0
commit 317b199b4a
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,3 +1,10 @@
2016-03-29 Florian Weimer <fweimer@redhat.com>
[BZ #19879]
CVE-2016-3075
* resolv/nss_dns/dns-network.c (_nss_dns_getnetbyname_r): Do not
copy name.
2016-03-29 Florian Weimer <fweimer@redhat.com> 2016-03-29 Florian Weimer <fweimer@redhat.com>
[BZ #19837] [BZ #19837]

5
resolv/nss_dns/dns-network.c
View File

@ -118,17 +118,14 @@ _nss_dns_getnetbyname_r (const char *name, struct netent *result,
} net_buffer; } net_buffer;
querybuf *orig_net_buffer; querybuf *orig_net_buffer;
int anslen; int anslen;
char *qbuf;
enum nss_status status; enum nss_status status;
if (__res_maybe_init (&_res, 0) == -1) if (__res_maybe_init (&_res, 0) == -1)
return NSS_STATUS_UNAVAIL; return NSS_STATUS_UNAVAIL;
qbuf = strdupa (name);
net_buffer.buf = orig_net_buffer = (querybuf *) alloca (1024); net_buffer.buf = orig_net_buffer = (querybuf *) alloca (1024);
anslen = __libc_res_nsearch (&_res, qbuf, C_IN, T_PTR, net_buffer.buf->buf, anslen = __libc_res_nsearch (&_res, name, C_IN, T_PTR, net_buffer.buf->buf,
1024, &net_buffer.ptr, NULL, NULL, NULL, NULL); 1024, &net_buffer.ptr, NULL, NULL, NULL, NULL);
if (anslen < 0) if (anslen < 0)
{ {