lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-28 00:21:52 +03:00
Code Activity

Deprecate the use of regexp.h

Browse Source 
<regexp.h> (not to be confused with <regex.h>) is an obsolete and
frankly horrible regular expression-matching API.  It was part of SVID
but was withdrawn in Issue 5 (for reference, we're on Issue 7 now).
It doesn't do anything you can't do with <regex.h>, and using it
involves defining a bunch of macros before including the header.
Moreover, the code in regexp.h that uses those macros has been buggy
since its creation (in 1996) and no one has noticed, which indicates
to me that there are no users.  (Specifically, RETURN() is used in a
whole bunch of cases where it should have been ERROR().)

The header is given a warning and marked deprecated for 2.22.

See:
https://sourceware.org/ml/libc-alpha/2015-07/msg00862.html and
https://sourceware.org/ml/libc-alpha/2015-07/msg00871.html.
This commit is contained in:
Zack Weinberg
2015-08-01 14:38:05 -04:00
committed by Carlos O'Donell
parent f4ddb3557e
commit 2ec11c2b6e
4 changed files with 39 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
misc/regexp.c
View File

@ -17,8 +17,10 @@
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
#define __DO_NOT_DEFINE_COMPILE
#include <regexp.h>
/* We don't include regexp.h here because of the macros it requires, and
because it now contains an unconditional #warning. */
#include <regex.h>
/* Define the variables used for the interface. */
char *loc1;
@ -32,7 +34,6 @@ char *locs;
found in the buffer starting at EXPBUF. `loc1' will return the
first character matched and `loc2' points to the next unmatched
character. */
extern int __step (const char *string, const char *expbuf);
int
__step (const char *string, const char *expbuf)
{
@ -55,7 +56,6 @@ weak_alias (__step, step)
/* Match the beginning of STRING with the compiled regular expression
in EXPBUF. If the match is successful `loc2' will contain the
position of the first unmatched character. */
extern int __advance (const char *string, const char *expbuf);
int
__advance (const char *string, const char *expbuf)
{