lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-09-14 00:41:56 +03:00
Code Activity

elf: ldconfig should skip temporary files created by package managers

Browse Source 
This avoids crashes due to partially written files, after a package
update is interrupted.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
This commit is contained in:
Florian Weimer
2023-10-20 14:29:50 +02:00
parent f5677d9ceb
commit 2aa0974d25
2 changed files with 30 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
NEWS
View File

@@ -40,7 +40,9 @@ Major new features:
Deprecated and removed features, and other changes affecting compatibility: Deprecated and removed features, and other changes affecting compatibility:
[Add deprecations, removals and changes affecting compatibility here] * The ldconfig program now skips file names containing ';' or ending in
".tmp", to avoid examining temporary files created by the RPM and dpkg
package managers.
Changes to build and runtime requirements: Changes to build and runtime requirements:

39
elf/ldconfig.c
View File

@@ -661,6 +661,31 @@ struct dlib_entry
struct dlib_entry *next; struct dlib_entry *next;
}; };
/* Skip some temporary DSO files. These files may be partially written
and lead to ldconfig crashes when examined. */
static bool
skip_dso_based_on_name (const char *name, size_t len)
{
/* Skip temporary files created by the prelink program. Files with
names like these are never really DSOs we want to look at. */
if (len >= sizeof (".#prelink#") - 1)
{
if (strcmp (name + len - sizeof (".#prelink#") + 1,
".#prelink#") == 0)
return true;
if (len >= sizeof (".#prelink#.XXXXXX") - 1
&& memcmp (name + len - sizeof (".#prelink#.XXXXXX")
+ 1, ".#prelink#.", sizeof (".#prelink#.") - 1) == 0)
return true;
}
/* Skip temporary files created by RPM. */
if (memchr (name, len, ';') != NULL)
return true;
/* Skip temporary files created by dpkg. */
if (len > 4 && memcmp (name + len - 4, ".tmp", 4) == 0)
return true;
return false;
}
static void static void
search_dir (const struct dir_entry *entry) search_dir (const struct dir_entry *entry)
@@ -711,18 +736,8 @@ search_dir (const struct dir_entry *entry)
continue; continue;
size_t len = strlen (direntry->d_name); size_t len = strlen (direntry->d_name);
/* Skip temporary files created by the prelink program. Files with if (skip_dso_based_on_name (direntry->d_name, len))
names like these are never really DSOs we want to look at. */ continue;
if (len >= sizeof (".#prelink#") - 1)
{
if (strcmp (direntry->d_name + len - sizeof (".#prelink#") + 1,
".#prelink#") == 0)
continue;
if (len >= sizeof (".#prelink#.XXXXXX") - 1
&& memcmp (direntry->d_name + len - sizeof (".#prelink#.XXXXXX")
+ 1, ".#prelink#.", sizeof (".#prelink#.") - 1) == 0)
continue;
}
if (asprintf (&file_name, "%s/%s", entry->path, direntry->d_name) < 0) if (asprintf (&file_name, "%s/%s", entry->path, direntry->d_name) < 0)
error (EXIT_FAILURE, errno, _("Could not form library path")); error (EXIT_FAILURE, errno, _("Could not form library path"));
if (opt_chroot != NULL) if (opt_chroot != NULL)