1
0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-28 00:21:52 +03:00

Annotate additional APIs with GCC attribute access.

This change continues the improvements to compile-time out of bounds
checking by decorating more APIs with either attribute access, or by
explicitly providing the array bound in APIs such as tmpnam() that
expect arrays of some minimum size as arguments.  (The latter feature
is new in GCC 11.)

The only effects of the attribute and/or the array bound is to check
and diagnose calls to the functions that fail to provide a sufficient
number of elements, and the definitions of the functions that access
elements outside the specified bounds.  (There is no interplay with
_FORTIFY_SOURCE here yet.)

Tested with GCC 7 through 11 on x86_64-linux.
This commit is contained in:
Martin Sebor
2021-05-06 10:56:25 -06:00
parent 3f0808ef4c
commit 26492c0a14
16 changed files with 95 additions and 45 deletions

View File

@ -44,6 +44,7 @@
#include <sys/time.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <libc-diag.h>
/* This is not an exhaustive test: only system calls that can be
persuaded to fail with a consistent error code and no side effects
@ -171,7 +172,18 @@ do_test (void)
allocation. */
fails |= test_wrp2 (LIST (EINVAL, ENOMEM), mlock, (void *) -1, 1);
fails |= test_wrp (EINVAL, nanosleep, &ts, &ts);
DIAG_POP_NEEDS_COMMENT;
#if __GNUC_PREREQ (9, 0)
/* Suppress valid GCC warning:
'poll' specified size 18446744073709551608 exceeds maximum object size
*/
DIAG_IGNORE_NEEDS_COMMENT (9, "-Wstringop-overflow=");
#endif
fails |= test_wrp (EINVAL, poll, &pollfd, -1, 0);
DIAG_POP_NEEDS_COMMENT;
/* quotactl returns ENOSYS for kernels not configured with
CONFIG_QUOTA, and may return EPERM if called within certain types
of containers. Linux 5.4 added additional argument validation