lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-09-07 01:26:44 +03:00
Code Activity

memset: fix define usage for shared libs

Browse Source 
The proper define to check "am I in a shared lib" is "SHARED", not "PIC".
The two new memset_chk functions incorrectly depend on "PIC".

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This commit is contained in:
Mike Frysinger
2011-02-22 13:26:19 -05:00
parent 5ed848f3d8
commit 1e4920e080
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@@ -1,3 +1,8 @@
2012-04-07 Mike Frysinger <vapier@gentoo.org>
* sysdeps/i386/i686/memset_chk.S: Change PIC to SHARED.
* sysdeps/x86_64/memset_chk.S: Likewise.
2012-04-07 David S. Miller <davem@davemloft.net> 2012-04-07 David S. Miller <davem@davemloft.net>
* elf/elf.h (R_SPARC_WDISP10): Define. * elf/elf.h (R_SPARC_WDISP10): Define.

2
sysdeps/i386/i686/memset_chk.S
View File

@@ -19,7 +19,7 @@
#include <sysdep.h> #include <sysdep.h>
#include "asm-syntax.h" #include "asm-syntax.h"
#ifndef PIC #ifndef SHARED
/* For libc.so this is defined in memset.S. /* For libc.so this is defined in memset.S.
For libc.a, this is a separate source to avoid For libc.a, this is a separate source to avoid
memset bringing in __chk_fail and all routines memset bringing in __chk_fail and all routines

2
sysdeps/x86_64/memset_chk.S
View File

@@ -19,7 +19,7 @@
#include <sysdep.h> #include <sysdep.h>
#include "asm-syntax.h" #include "asm-syntax.h"
#ifndef PIC #ifndef SHARED
/* For libc.so this is defined in memset.S. /* For libc.so this is defined in memset.S.
For libc.a, this is a separate source to avoid For libc.a, this is a separate source to avoid
memset bringing in __chk_fail and all routines memset bringing in __chk_fail and all routines