lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-12-06 12:01:08 +03:00
Code Activity

math: Handle fabsf128 !__USE_EXTERN_INLINES

Browse Source 
Work around the clang limitation wrt inline function and attribute
definition, where it does not allow to 'add' new attribute if a
function is already defined:

clang on x86_64 fails to build s_fabsf128.c with:

../sysdeps/ieee754/float128/../ldbl-128/s_fabsl.c:32:1: error: attribute declaration must precede definition [-Werror,-Wignored-attributes]
   32 | libm_alias_ldouble (__fabs, fabs)
      | ^
../sysdeps/generic/libm-alias-ldouble.h:63:38: note: expanded from macro 'libm_alias_ldouble'
   63 | #define libm_alias_ldouble(from, to) libm_alias_ldouble_r (from, to, )
      |                                      ^
../sysdeps/ieee754/float128/float128_private.h:133:43: note: expanded from macro 'libm_alias_ldouble_r'
  133 | #define libm_alias_ldouble_r(from, to, r) libm_alias_float128_r (from, to, r)
      |                                           ^
../sysdeps/ieee754/float128/s_fabsf128.c:5:3: note: expanded from macro 'libm_alias_float128_r'
    5 |   static_weak_alias (from ## f128 ## r, to ## f128 ## r);       \
      |   ^
./../include/libc-symbols.h:166:46: note: expanded from macro 'static_weak_alias'
  166 | #  define static_weak_alias(name, aliasname) weak_alias (name, aliasname)
      |                                              ^
./../include/libc-symbols.h:154:38: note: expanded from macro 'weak_alias'
  154 | # define weak_alias(name, aliasname) _weak_alias (name, aliasname)
      |                                      ^
./../include/libc-symbols.h:156:52: note: expanded from macro '_weak_alias'
  156 |   extern __typeof (name) aliasname __attribute__ ((weak, alias (#name))) \
      |                                                    ^
../include/math.h:134:1: note: previous definition is here
  134 | fabsf128 (_Float128 x)

If compiler does not support __USE_EXTERN_INLINES we need to route
fabsf128 call to an internal symbol.
This commit is contained in:
Adhemerval Zanella
2025-11-10 10:29:01 -03:00
parent 53ad1eae0f
commit 1abdb38135
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/math.h
View File

@@ -114,6 +114,8 @@ __issignalingf (float x)
# if __HAVE_DISTINCT_FLOAT128 # if __HAVE_DISTINCT_FLOAT128
# ifdef __USE_EXTERN_INLINES
/* __builtin_isinf_sign is broken in GCC < 7 for float128. */ /* __builtin_isinf_sign is broken in GCC < 7 for float128. */
# if ! __GNUC_PREREQ (7, 0) # if ! __GNUC_PREREQ (7, 0)
# include <ieee754_float128.h> # include <ieee754_float128.h>
@@ -133,6 +135,9 @@ fabsf128 (_Float128 x)
{ {
return __builtin_fabsf128 (x); return __builtin_fabsf128 (x);
} }
# else
libm_hidden_proto (fabsf128)
# endif
# endif # endif

3
sysdeps/ieee754/float128/s_fabsf128.c
View File

@@ -1,2 +1,5 @@
#include <float128_private.h> #include <float128_private.h>
#include "../ldbl-128/s_fabsl.c" #include "../ldbl-128/s_fabsl.c"
#ifndef __USE_EXTERN_INLINES
libm_hidden_def (fabsf128)
#endif