lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-28 00:21:52 +03:00
Code Activity

Disable strncat test array-bounds warnings for GCC 8.

Browse Source 
Some strncat tests fail to build with GCC 8 because of -Warray-bounds
warnings.  These tests are deliberately test over-large size arguments
passed to strncat, and already disable -Wstringop-overflow warnings,
but now the warnings for these tests come under -Warray-bounds so that
option needs disabling for them as well, which this patch does (with
an update on the comments; the DIAG_IGNORE_NEEDS_COMMENT call for
-Warray-bounds doesn't need to be conditional itself, because that
option is supported by all versions of GCC that can build glibc).

Tested compilation with build-many-glibcs.py for aarch64-linux-gnu.

	* string/tester.c (test_strncat): Also disable -Warray-bounds
	warnings for two tests.
This commit is contained in:
Joseph Myers
2017-12-18 22:52:41 +00:00
parent 00c714df39
commit 1421f39b7e
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2017-12-18 Joseph Myers <joseph@codesourcery.com>
* string/tester.c (test_strncat): Also disable -Warray-bounds
warnings for two tests.
2017-12-18 H.J. Lu <hongjiu.lu@intel.com> 2017-12-18 H.J. Lu <hongjiu.lu@intel.com>
[BZ #22614] [BZ #22614]

8
string/tester.c
View File

@ -387,9 +387,11 @@ test_strncat (void)
DIAG_PUSH_NEEDS_COMMENT; DIAG_PUSH_NEEDS_COMMENT;
#if __GNUC_PREREQ (7, 0) #if __GNUC_PREREQ (7, 0)
/* GCC 7 warns about the size passed to strncat being larger than /* GCC 7 warns about the size passed to strncat being larger than
the size of the buffer; this is deliberately tested here.. */ the size of the buffer; this is deliberately tested here; GCC 8
gives a -Warray-bounds warning about this. */
DIAG_IGNORE_NEEDS_COMMENT (7, "-Wstringop-overflow="); DIAG_IGNORE_NEEDS_COMMENT (7, "-Wstringop-overflow=");
#endif #endif
DIAG_IGNORE_NEEDS_COMMENT (8, "-Warray-bounds");
(void) strncat (one, two, 99); (void) strncat (one, two, 99);
DIAG_POP_NEEDS_COMMENT; DIAG_POP_NEEDS_COMMENT;
equal (one, "ghef", 5); /* Basic test encore. */ equal (one, "ghef", 5); /* Basic test encore. */
@ -480,9 +482,11 @@ test_strncat (void)
#if __GNUC_PREREQ (7, 0) #if __GNUC_PREREQ (7, 0)
/* GCC 7 warns about the size passed to strncat being /* GCC 7 warns about the size passed to strncat being
larger than the size of the buffer; this is larger than the size of the buffer; this is
deliberately tested here.. */ deliberately tested here; GCC 8 gives a -Warray-bounds
warning about this. */
DIAG_IGNORE_NEEDS_COMMENT (7, "-Wstringop-overflow="); DIAG_IGNORE_NEEDS_COMMENT (7, "-Wstringop-overflow=");
#endif #endif
DIAG_IGNORE_NEEDS_COMMENT (8, "-Warray-bounds");
check (strncat (buf1 + n2, buf2 + n1, ~((size_t) 0) - n4) check (strncat (buf1 + n2, buf2 + n1, ~((size_t) 0) - n4)
== buf1 + n2, ntest); == buf1 + n2, ntest);
DIAG_POP_NEEDS_COMMENT; DIAG_POP_NEEDS_COMMENT;