lib/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-07-28 00:21:52 +03:00
Code Activity

Fix build-many-glibcs.py style issues.

Browse Source 
* scripts/build-many-glibcs.py (os.path): Do not import.
	(Context): Inherit explicitly from object.  Remove blank line
	between class and docstring.
	(Config): Likewise.
	(Glibc): Likewise.
	(Command): Likewise.
	(CommandList): Likewise.
	(Context.write_files): Store chmod mode in a variable.
This commit is contained in:
Joseph Myers
2016-11-14 23:48:50 +00:00
parent ba1cafea16
commit 0c95f51d84
2 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@ -1,5 +1,14 @@
2016-11-14 Joseph Myers <joseph@codesourcery.com> 2016-11-14 Joseph Myers <joseph@codesourcery.com>
* scripts/build-many-glibcs.py (os.path): Do not import.
(Context): Inherit explicitly from object. Remove blank line
between class and docstring.
(Config): Likewise.
(Glibc): Likewise.
(Command): Likewise.
(CommandList): Likewise.
(Context.write_files): Store chmod mode in a variable.
* sysdeps/unix/sysv/linux/tile/tilegx/configure.ac: Use * sysdeps/unix/sysv/linux/tile/tilegx/configure.ac: Use
LIBC_SLIBDIR_RTLDDIR for tilegx32. LIBC_SLIBDIR_RTLDDIR for tilegx32.
* sysdeps/unix/sysv/linux/tile/tilegx/configure: Regenerated. * sysdeps/unix/sysv/linux/tile/tilegx/configure: Regenerated.

27
scripts/build-many-glibcs.py
View File

@ -33,7 +33,6 @@ configurations for which compilers or glibc are to be built.
import argparse import argparse
import os import os
import os.path
import re import re
import shutil import shutil
import stat import stat
@ -42,8 +41,7 @@ import sys
import urllib.request import urllib.request
class Context: class Context(object):
"""The global state associated with builds in a given directory.""" """The global state associated with builds in a given directory."""
def __init__(self, topdir, parallelism, keep, action): def __init__(self, topdir, parallelism, keep, action):
@ -460,9 +458,10 @@ class Context:
'record_status PASS\n') 'record_status PASS\n')
with open(self.wrapper, 'w') as f: with open(self.wrapper, 'w') as f:
f.write(wrapper_text) f.write(wrapper_text)
os.chmod(self.wrapper, # Mode 0o755.
(stat.S_IRWXU|stat.S_IRGRP|stat.S_IXGRP| mode_exec = (stat.S_IRWXU|stat.S_IRGRP|stat.S_IXGRP|
stat.S_IROTH|stat.S_IXOTH)) stat.S_IROTH|stat.S_IXOTH)
os.chmod(self.wrapper, mode_exec)
save_logs_text = ( save_logs_text = (
'#!/bin/sh\n' '#!/bin/sh\n'
'if ! [ -f tests.sum ]; then\n' 'if ! [ -f tests.sum ]; then\n'
@ -487,9 +486,7 @@ class Context:
'done\n') 'done\n')
with open(self.save_logs, 'w') as f: with open(self.save_logs, 'w') as f:
f.write(save_logs_text) f.write(save_logs_text)
os.chmod(self.save_logs, os.chmod(self.save_logs, mode_exec)
(stat.S_IRWXU|stat.S_IRGRP|stat.S_IXGRP|
stat.S_IROTH|stat.S_IXOTH))
def do_build(self): def do_build(self):
"""Do the actual build.""" """Do the actual build."""
@ -678,8 +675,7 @@ class Context:
os.remove(filename) os.remove(filename)
class Config: class Config(object):
"""A configuration for building a compiler and associated libraries.""" """A configuration for building a compiler and associated libraries."""
def __init__(self, ctx, arch, os_name, variant=None, gcc_cfg=None, def __init__(self, ctx, arch, os_name, variant=None, gcc_cfg=None,
@ -846,8 +842,7 @@ class Config:
self.build_cross_tool(cmdlist, 'gcc', tool_build, cfg_opts) self.build_cross_tool(cmdlist, 'gcc', tool_build, cfg_opts)
class Glibc: class Glibc(object):
"""A configuration for building glibc.""" """A configuration for building glibc."""
def __init__(self, compiler, arch=None, os_name=None, variant=None, def __init__(self, compiler, arch=None, os_name=None, variant=None,
@ -958,8 +953,7 @@ class Glibc:
cmdlist.cleanup_dir() cmdlist.cleanup_dir()
class Command: class Command(object):
"""A command run in the build process.""" """A command run in the build process."""
def __init__(self, desc, num, dir, path, command, always_run=False): def __init__(self, desc, num, dir, path, command, always_run=False):
@ -999,8 +993,7 @@ class Command:
return self.shell_make_quote_list(self.command, True) return self.shell_make_quote_list(self.command, True)
class CommandList: class CommandList(object):
"""A list of commands run in the build process.""" """A list of commands run in the build process."""
def __init__(self, desc, keep): def __init__(self, desc, keep):