mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2026-10-24 00:49:00 +03:00
016829559e
g_type_ensure has a large comment saying _get_type shouldn't be marked with G_GNUC_CONST because it has side-effects on the first run, but it's OK if you consistently call g_type_ensure first. Unfortunately, this isn't accurate. GCC trunk (observed at r17-1725-ge259a182e1f100) now analyses points-to information more effectively and propagates its findings, so it sees the function modifies some global state, concludes that can't be possible (because of the const attribute), and deletes the stores. pure unfortunately is unsuitable for *_get_type too as it has a side-effect (writes to global memory). Mesa had a similar issue which I fixed recently [0]. glib and glibmm likely want the (not-yet-implemented) 'idempotent' attribute instead [1]. In fact, this exact problem is what motivated that request! :) ebassi mentions an alternative to the current setup as well, using atomics [2]. This problem has gone back many years but the compiler has finally fully outsmarted us here, so give in. [0] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/42361 [1] https://gcc.gnu.org/PR32911 [2] https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4249#note_2583110 Fixes: https://gitlab.gnome.org/GNOME/glib/-/work_items/3984 Signed-off-by: Sam James <sam@gentoo.org>
61 lines
2.6 KiB
C
61 lines
2.6 KiB
C
/* GIO - GLib Input, Output and Streaming Library
|
|
*
|
|
* Copyright © 2008 Christian Kellner, Samuel Cormier-Iijima
|
|
* Copyright © 2009 Codethink Limited
|
|
*
|
|
* SPDX-License-Identifier: LGPL-2.1-or-later
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* See the included COPYING file for more information.
|
|
*
|
|
* Authors: Christian Kellner <gicmo@gnome.org>
|
|
* Samuel Cormier-Iijima <sciyoshi@gmail.com>
|
|
* Ryan Lortie <desrt@desrt.ca>
|
|
*/
|
|
|
|
#ifndef __G_SOCKET_OUTPUT_STREAM_H__
|
|
#define __G_SOCKET_OUTPUT_STREAM_H__
|
|
|
|
#include <gio/goutputstream.h>
|
|
#include <gio/gsocket.h>
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
#define G_TYPE_SOCKET_OUTPUT_STREAM (_g_socket_output_stream_get_type ())
|
|
#define G_SOCKET_OUTPUT_STREAM(inst) (G_TYPE_CHECK_INSTANCE_CAST ((inst), \
|
|
G_TYPE_SOCKET_OUTPUT_STREAM, GSocketOutputStream))
|
|
#define G_SOCKET_OUTPUT_STREAM_CLASS(class) (G_TYPE_CHECK_CLASS_CAST ((class), \
|
|
G_TYPE_SOCKET_OUTPUT_STREAM, GSocketOutputStreamClass))
|
|
#define G_IS_SOCKET_OUTPUT_STREAM(inst) (G_TYPE_CHECK_INSTANCE_TYPE ((inst), \
|
|
G_TYPE_SOCKET_OUTPUT_STREAM))
|
|
#define G_IS_SOCKET_OUTPUT_STREAM_CLASS(class) (G_TYPE_CHECK_CLASS_TYPE ((class), \
|
|
G_TYPE_SOCKET_OUTPUT_STREAM))
|
|
#define G_SOCKET_OUTPUT_STREAM_GET_CLASS(inst) (G_TYPE_INSTANCE_GET_CLASS ((inst), \
|
|
G_TYPE_SOCKET_OUTPUT_STREAM, GSocketOutputStreamClass))
|
|
|
|
typedef struct _GSocketOutputStreamPrivate GSocketOutputStreamPrivate;
|
|
typedef struct _GSocketOutputStreamClass GSocketOutputStreamClass;
|
|
typedef struct _GSocketOutputStream GSocketOutputStream;
|
|
|
|
struct _GSocketOutputStreamClass
|
|
{
|
|
GOutputStreamClass parent_class;
|
|
};
|
|
|
|
struct _GSocketOutputStream
|
|
{
|
|
GOutputStream parent_instance;
|
|
GSocketOutputStreamPrivate *priv;
|
|
};
|
|
|
|
GType _g_socket_output_stream_get_type (void);
|
|
GSocketOutputStream * _g_socket_output_stream_new (GSocket *socket);
|
|
|
|
G_END_DECLS
|
|
|
|
#endif /* __G_SOCKET_OUTPUT_STREAM_H__ */
|