From 95fa8de2c3e9ab36282e42678fcd1c8f9208c5dc Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Fri, 11 Apr 2025 21:57:12 +0100 Subject: [PATCH] gmodule: Enable -Wsign-conversion for gmodule subdirectory There was only one `-Wsign-conversion` warning in the whole subdirectory, so that was easy. Signed-off-by: Philip Withnall Helps: #3405 --- gmodule/gmodule.c | 2 +- gmodule/meson.build | 2 +- gmodule/tests/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gmodule/gmodule.c b/gmodule/gmodule.c index f0ba81b2e..8bdcd9da0 100644 --- a/gmodule/gmodule.c +++ b/gmodule/gmodule.c @@ -481,7 +481,7 @@ g_module_open_full (const gchar *file_name, _g_module_debug_init (); if (module_debug_flags & G_MODULE_DEBUG_BIND_NOW_MODULES) - flags &= ~G_MODULE_BIND_LAZY; + flags &= (unsigned) ~G_MODULE_BIND_LAZY; if (!file_name) { diff --git a/gmodule/meson.build b/gmodule/meson.build index f91924635..37a8fa42d 100644 --- a/gmodule/meson.build +++ b/gmodule/meson.build @@ -96,7 +96,7 @@ libgmodule = library('gmodule-2.0', install : true, include_directories : [configinc, gmoduleinc], dependencies : [libdl_dep, libglib_dep], - c_args : ['-DG_LOG_DOMAIN="GModule"', '-DGMODULE_COMPILATION'], + c_args : ['-DG_LOG_DOMAIN="GModule"', '-DGMODULE_COMPILATION', warning_sign_conversion_args], gnu_symbol_visibility : 'hidden', link_args : [glib_link_flags], ) diff --git a/gmodule/tests/meson.build b/gmodule/tests/meson.build index 5374c1c2a..e7d7b3dd1 100644 --- a/gmodule/tests/meson.build +++ b/gmodule/tests/meson.build @@ -75,7 +75,7 @@ test_env.set('G_TEST_SRCDIR', meson.current_source_dir()) test_env.set('G_TEST_BUILDDIR', meson.current_build_dir()) test_deps = [libm, thread_dep, libglib_dep, libgmodule_dep] -test_cargs = ['-DG_LOG_DOMAIN="GModule"', '-UG_DISABLE_ASSERT'] +test_cargs = ['-DG_LOG_DOMAIN="GModule"', '-UG_DISABLE_ASSERT', warning_sign_conversion_args] test_cpp_args = test_cargs foreach test_name, extra_args : gmodule_tests