lib/cpp-httplib
1
0
Fork 0
mirror of synced 2025-04-21 22:25:55 +03:00
Code

Avoid a -Warray-bounds false positive in GCC 13. (#1639)

Browse Source 
The exact circumstances when this false positive is triggered are quite
tricky to reproduce, but it happened reproducibly with g++ 13.1 and 13.2 in
a close-source SW I'm working on.  The fix even improves performance by a
very tiny bit: There is no need to copy the std::smatch, having a const
reference is enough.

Just as a side note: -Warray-bounds seems to cause trouble in other
projects, too, so e.g. the Linux kernel has disabled since June 2022.
This commit is contained in:
Sven Panne 2023-08-14 16:26:54 +02:00 committed by GitHub
parent 67f6ff7fa9
commit afe627e7af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
httplib.h
View File

@ -4986,7 +4986,7 @@ inline bool parse_www_authenticate(const Response &res,
s = s.substr(pos + 1); s = s.substr(pos + 1);
auto beg = std::sregex_iterator(s.begin(), s.end(), re); auto beg = std::sregex_iterator(s.begin(), s.end(), re);
for (auto i = beg; i != std::sregex_iterator(); ++i) { for (auto i = beg; i != std::sregex_iterator(); ++i) {
auto m = *i; const auto &m = *i;
auto key = s.substr(static_cast<size_t>(m.position(1)), auto key = s.substr(static_cast<size_t>(m.position(1)),
static_cast<size_t>(m.length(1))); static_cast<size_t>(m.length(1)));
auto val = m.length(2) > 0 auto val = m.length(2) > 0