lib/cpp-httplib
1
0
Fork 0
mirror of synced 2025-11-06 18:49:27 +03:00
Code Activity

Fix HTTP 414 errors hanging until timeout (#2260)

Browse Source 
* Fix HTTP 414 errors hanging until timeout

* All errors (status code 400+) close the connection

* 🧹

---------

Co-authored-by: Wor Ker <worker@factory>
This commit is contained in:
chansikpark
2025-11-02 22:23:42 -05:00
committed by GitHub
parent 551f96d4a2
commit 4b2b851dbb
2 changed files with 46 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
httplib.h
View File

@@ -7692,7 +7692,8 @@ inline bool Server::write_response_core(Stream &strm, bool close_connection,
if (need_apply_ranges) { apply_ranges(req, res, content_type, boundary); }
// Prepare additional headers
if (close_connection || req.get_header_value("Connection") == "close") {
if (close_connection || req.get_header_value("Connection") == "close" ||
400 <= res.status) { // Don't leave connections open after errors
res.set_header("Connection", "close");
} else {
std::string s = "timeout=";
@@ -8403,8 +8404,6 @@ Server::process_request(Stream &strm, const std::string &remote_addr,
// Check if the request URI doesn't exceed the limit
if (req.target.size() > CPPHTTPLIB_REQUEST_URI_MAX_LENGTH) {
Headers dummy;
detail::read_headers(strm, dummy);
res.status = StatusCode::UriTooLong_414;
output_error_log(Error::ExceedUriMaxLength, &req);
return write_response(strm, close_connection, req, res);