mirror of
https://git.savannah.gnu.org/git/coreutils.git
synced 2026-11-19 03:33:43 +03:00
glibc <= 2.5 would crash when passed invalid long double values, therefore internal gnulib routines were used, essentially only by od, to output such invalid values. Later glibc versions don't crash, as per https://sourceware.org/bugzilla/show_bug.cgi?id=4586 and subsequently od was adjusted to use the system printf routines through the use of the ftoastr module with commit v8.7-22-ga71c22f. Consequently our testing of this feature was moot, and use of the gnulib printf replacement for printf(1), od(1) and error(3) etc. was redundant. * configure.ac (gl_printf_safe): Unset so that we don't check that "nan" is output for these long double values. * tests/misc/od-float.sh: Adjust all existing checks to fail if od exits with failure status (like crashing for example). Add a new case for one of the problematic invalid long double values for x86_64. We only check that od exits successfully at present, which may change if https://sourceware.org/bugzilla/show_bug.cgi?id=17661 is resolved.
73 lines
2.3 KiB
Bash
Executable File
73 lines
2.3 KiB
Bash
Executable File
#!/bin/sh
|
|
# Test od on floating-point values.
|
|
|
|
# Copyright (C) 2010-2014 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src
|
|
print_ver_ od
|
|
|
|
export LC_ALL=C
|
|
|
|
# Test for a bug in coreutils up through 8.7: od was losing
|
|
# information when asked to parse floating-point values. The numeric
|
|
# tests are valid only on Intel-like hosts, but that should be good
|
|
# enough to detect regressions, as they are designed to succeed on
|
|
# non-Intel-like hosts. Also, test for another bug in coreutils 8.7
|
|
# on x86: sometimes there was no space between the columns.
|
|
|
|
set x $(echo aaaabaaa | tr ab '\376\377' | od -t fF) ||
|
|
fail=1
|
|
case "$*" in
|
|
*0-*) fail=1;;
|
|
esac
|
|
case $3,$4 in
|
|
-1.694740e+38,-1.694740e+38) fail=1;;
|
|
esac
|
|
|
|
set x $(echo aaaaaaaabaaaaaaa | tr ab '\376\377' | od -t fD) ||
|
|
fail=1
|
|
case "$*" in
|
|
*0-*) fail=1;;
|
|
esac
|
|
case $3,$4 in
|
|
-5.314010372517808e+303,-5.314010372517808e+303) fail=1;;
|
|
esac
|
|
|
|
set x $(echo aaaaaaaaaaaaaaaabaaaaaaaaaaaaaaa | tr ab '\376\377' | od -t fL) ||
|
|
fail=1
|
|
case "$*" in
|
|
*0-*) fail=1;;
|
|
esac
|
|
case $3,$4 in
|
|
-1.023442870282055988e+4855,-1.023442870282055988e+4855) fail=1;;
|
|
esac
|
|
|
|
# Ensure od doesn't crash as it did on glibc <= 2.5:
|
|
# https://sourceware.org/bugzilla/show_bug.cgi?id=4586
|
|
set x $(printf 00000000ff000000 | tr 0f '\000\377' | od -t fL) || fail=1
|
|
# With coreutils <= 8.7 we used to print "nan" for the above invalid value.
|
|
# However since v8.7-22-ga71c22f we deferred to the system printf routines
|
|
# through the use of the ftoastr module. So the following check would only
|
|
# be valid on x86_64 if we again handle the conversion internally or
|
|
# if this glibc bug is resolved:
|
|
# https://sourceware.org/bugzilla/show_bug.cgi?id=17661
|
|
#case "$*" in
|
|
#*nan*) ;;
|
|
#*) fail=1;;
|
|
#esac
|
|
|
|
Exit $fail
|