Files
coreutils/tests/mv/atomic2
T
Jim Meyering 63feb84a2d mv: never unlink a destination file before calling rename
While cp --preserve=links must unlink certain destination files,
mv must never do that.
* src/copy.c (copy_internal): Pull the '! x->move_mode' test "up",
so it affects the entire condition, and not just DEREF_NEVER mode.
Reported by James Ralston in <http://bugzilla.redhat.com/438076>.
* tests/mv/atomic2: New file.  Test for the above fix.
* tests/mv/Makefile.am (TESTS): Add atomic2.
* NEWS: Mention the bug-fix.
[Bug introduced in 367719ba5f]
2008-03-19 13:38:27 +01:00

51 lines
1.5 KiB
Bash
Executable File

#!/bin/sh
# ensure that mv doesn't first unlink a multi-hard-linked destination
# Copyright (C) 2008 Free Software Foundation, Inc.
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
if test "$VERBOSE" = yes; then
set -x
mv --version
fi
. $srcdir/../test-lib.sh
require_strace_
# Before the fix, mv would unnecessarily unlink the destination symlink:
# $ rm -f a b b2; touch a b; ln b b2; strace -e unlink /p/bin/mv a b
# unlink("b") = 0
#
# With the fix, it doesn't call unlink:
# $ rm -f a b b2; touch a b; ln b b2; strace -e unlink ./mv a b
# $
touch a b || framework_failure
ln b b2 || framework_failure
fail=0
strace -qe unlink mv a b > out 2>&1 || fail=1
$EGREP 'unlink.*"b"' out && fail=1
# Ensure that the source, "a", is gone.
ls -dl a > /dev/null 2>&1 && fail=1
# Ensure that the destination, "b", has link count 1.
n_links=`stat --printf=%h b` || fail=1
test "$n_links" = 1 || fail=1
(exit $fail); exit $fail