Files
coreutils/tests/split/numeric.sh
T
Ismail Ramzi a65907555f split: fix out-of-bounds read with --hex-suffixes=FROM
When FROM contained the digits a-f, next_file_name() derived the
suffix index with c - '0', giving values up to 54 for a 16 character
alphabet.  Incrementing the suffix then read past the end of the
alphabet string and used those bytes in the output file names,
e.g., 'split --hex-suffixes=f' created x0f, x0s, x0u.

* src/split.c (next_file_name): Map start value characters through
the suffix alphabet rather than assuming decimal digits.
(main): Reject a start value not valid for the final suffix alphabet,
as can happen with --hex-suffixes=a --numeric-suffixes.
(set_suffix_length): Determine width using base 16 for hex suffixes.
* tests/split/numeric.sh: Add test cases.
* NEWS: Mention the bug fix.

Link: https://github.com/coreutils/coreutils/pull/404
Also discovered by Anthropic's OSS Scanner, as bug ANT-2026-DWADVADP.
2026-11-03 13:28:02 +00:00

75 lines
2.6 KiB
Bash
Executable File

#!/bin/sh
# Test --{hex,numeric}-suffixes[=from]
# Copyright (C) 2012-2026 Free Software Foundation, Inc.
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src
print_ver_ split
printf '1\n2\n3\n4\n5\n' > in || framework_failure_
printf '%s\n' 1 2 > exp-0 || framework_failure_
printf '%s\n' 3 4 > exp-1 || framework_failure_
printf '%s\n' 5 > exp-2 || framework_failure_
for mode in 'numeric' 'hex'; do
for start in 0 9; do
mode_option="--$mode-suffixes"
# check with and without specified start value
test $start != '0' && mode_option="$mode_option=$start"
split $mode_option --lines=2 in || fail=1
test $mode = 'hex' && format=x || format=d
for i in $(seq $start $(($start+2))); do
compare exp-$(($i-$start)) x$(printf %02$format $i) || fail=1
done
done
# Check that split failed when suffix length is not large enough for
# the numerical suffix start value
returns_ 1 split -a 3 --$mode-suffixes=1000 in 2>/dev/null || fail=1
# check invalid --$mode-suffixes start values are flagged
returns_ 1 split --$mode-suffixes=-1 in 2> /dev/null || fail=1
returns_ 1 split --$mode-suffixes=one in 2> /dev/null || fail=1
done
# Check hexadecimal start values that are not decimal digits
rm -f x?? || framework_failure_
split --hex-suffixes=f --lines=2 in || fail=1
compare exp-0 x0f || fail=1
compare exp-1 x10 || fail=1
compare exp-2 x11 || fail=1
# A hexadecimal start value is invalid for a later --numeric-suffixes
returns_ 1 split --hex-suffixes=a --numeric-suffixes in 2> /dev/null || fail=1
# Only the final alphabet needs to accommodate the retained start value.
split --hex-suffixes=a -d -x --lines=2 in || fail=1
compare exp-0 x0a || fail=1
compare exp-1 x0b || fail=1
compare exp-2 x0c || fail=1
# Interpret the start value as hex when determining the suffix length.
# 0x10 + 241 - 1 = 0x100, which requires three digits.
split --hex-suffixes=10 --number=r/241 in || fail=1
test -f x010 && test -f x100 || fail=1
returns_ 1 split -a2 --hex-suffixes=10 --number=r/241 in 2>/dev/null \
|| fail=1
Exit $fail