mirror of
https://git.savannah.gnu.org/git/coreutils.git
synced 2026-11-17 18:02:09 +03:00
Exempt init.sh because it runs before we're assured to have a
shell that groks $(...). Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run. Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...). Do that by running this command:
git grep -l '`.*`' tests \
| grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
| xargs perl -pi -e 's/`(.*?)`/\$($1)/g'
One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
- expected_perms=$(eval 'echo \$expected_'$dest)
+ expected_perms=$(eval 'echo $expected_'$dest)
Another was to make these required quoting adjustments:
diff --git a/tests/misc/stty b/tests/misc/stty
...
- rev=$(eval echo "\\\$REV_$opt")
+ rev=$(eval echo "\$REV_$opt")
...
- rev1=$(eval echo "\\\$REV_$opt1")
- rev2=$(eval echo "\\\$REV_$opt2")
+ rev1=$(eval echo "\$REV_$opt1")
+ rev2=$(eval echo "\$REV_$opt2")
Also, transform two files that were needlessly excluded above:
(both use perl, but are mostly bourne shell)
perl -pi -e 's/`(.*?)`/\$($1)/g' \
tests/du/long-from-unreadable tests/init.cfg
64 lines
1.8 KiB
Bash
Executable File
64 lines
1.8 KiB
Bash
Executable File
#!/bin/sh
|
|
# Make sure "chown USER:GROUP FILE" works, and similar tests with separators.
|
|
|
|
# Copyright (C) 2004-2012 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/init.sh"; path_prepend_ ../src
|
|
print_ver_ chown
|
|
|
|
id_u=$(id -u) || framework_failure_
|
|
test -n "$id_u" || framework_failure_
|
|
|
|
id_un=$(id -un) || framework_failure_
|
|
test -n "$id_un" || framework_failure_
|
|
|
|
id_g=$(id -g) || framework_failure_
|
|
test -n "$id_g" || framework_failure_
|
|
|
|
id_gn=$(id -gn) || framework_failure_
|
|
test -n "$id_gn" || framework_failure_
|
|
|
|
# FreeBSD 6.x's getgrnam fails to look up a group name containing
|
|
# a space. On such a system, skip this test if the group name contains
|
|
# a byte not in the portable filename character set.
|
|
case $host_triplet in
|
|
*-freebsd6.*)
|
|
case $id_gn in
|
|
*[^a-zA-Z0-9._-]*) skip_ "invalid group name: $id_gn";;
|
|
esac;;
|
|
*) ;;
|
|
esac
|
|
|
|
|
|
chown '' . || fail=1
|
|
|
|
for u in $id_u "$id_un" ''; do
|
|
for g in $id_g "$id_gn" ''; do
|
|
case $u$g in
|
|
*.*) seps=':' ;;
|
|
*) seps=': .' ;;
|
|
esac
|
|
for sep in $seps; do
|
|
case $u$sep$g in
|
|
[0-9]*$sep) chown "$u$sep$g" . 2> /dev/null && fail=1 ;;
|
|
*) chown "$u$sep$g" . || fail=1 ;;
|
|
esac
|
|
done
|
|
done
|
|
done
|
|
|
|
Exit $fail
|