Pádraig Brady
16c7267d74
maint: avoid new signed overflow warning on 32 bit
...
Prompted by http://hydra.nixos.org/build/15682577
with GCC 4.8.3 on i686
src/tac.c:557:6: error: assuming signed overflow does not occur
when simplifying conditional to constant [-Werror=strict-overflow]
if (bytes_copied < 0)
This happens because copy_to_temp() is inlined in tac_nonseekable(),
thus reducing the comparison to the bytes_copied variable in
copy_to_temp. Now this can't overflow on either 32 or 64 bit
due to the protection of the preceding fwrite(). We could use a
guard like "if (bytes_copied <= OFF_T_MAX - bytes_read)" to avoid
the warning, but rather than a runtime branch, just use an unsigned
type to avoid apparent signed overflow on systems where the accumulation
is not promoted to unsigned (32 bit size_t, 64 bit off_t).
* src/tac.c (copy_to_temp): Increment an unsigned type to
avoid the subsequent signed overflow warning.
2014-10-08 12:48:51 +01:00
..
2014-07-13 14:23:09 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2009-08-25 09:21:00 +02:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:25:23 +01:00
2014-01-02 22:19:59 +01:00
2014-09-08 20:48:44 -07:00
2014-09-08 20:48:44 -07:00
2014-09-08 20:48:44 -07:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2008-11-20 10:21:52 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2014-10-02 02:34:48 +02:00
2014-09-19 11:24:05 +01:00
2014-09-19 13:02:49 -07:00
2014-04-17 20:52:19 +01:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-08-23 01:23:20 +01:00
2014-08-22 12:07:38 -07:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2011-07-15 10:55:04 +01:00
2014-01-02 22:19:59 +01:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2014-10-07 16:47:37 -07:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-07-04 01:54:45 +02:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-10 23:53:36 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-10 23:46:54 +01:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2012-01-09 21:51:59 +01:00
2014-09-08 20:48:44 -07:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-24 11:48:22 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-10-07 16:47:37 -07:00
2014-01-02 22:19:59 +01:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2014-01-02 22:19:59 +01:00
2014-04-16 23:34:42 +01:00
2014-01-02 22:19:59 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-07-01 15:45:53 +01:00
2014-01-02 22:20:08 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-10-07 16:47:37 -07:00
2014-09-19 11:24:05 +01:00
2014-09-23 09:08:34 +01:00
2014-09-23 09:11:14 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-01-02 22:19:59 +01:00
2014-10-08 12:48:51 +01:00
2014-10-07 16:47:37 -07:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2007-07-10 19:00:00 +02:00
2007-07-10 19:00:00 +02:00
2014-09-19 11:24:05 +01:00
2012-01-09 21:51:59 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-10-07 16:47:37 -07:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00
2014-09-19 11:24:05 +01:00