Commit Graph
2200 Commits
Author SHA1 Message Date
Jim Meyering 1c904f14ea * tests/envvar-check: Add more variable names to the list of those
that can affect these programs and tests: _POSIX2_VERSION, COLUMNS,
QUOTING_STYLE, TABSIZE, TERM, TMPDIR.
2006-09-17 20:29:05 +00:00
Paul Eggert b67faf329c * NEWS: Document that mkdir -p and install -d now fork on occasion.
* bootstrap.conf (gnulib_modules): Add savewd.
* src/install.c: Include savewd.h.
(process_dir): New function.
(main, install_file_in_file_parents): Use it, along with the new
savewd module, to avoid some race conditions.
* src/mkdir.c: Include savewd.h.
(struct mkdir_options): New members make_ancestor_function, mode,
mode_bits.
(make_ancestor): Return 1 if the resulting directory is not readable.
(process_dir): New function.
(main): Use it, along with new savewd module, to avoid some
race conditions.  Fill in new slots of struct mkdir_options, so
that callees get the values.
* tests/install/basic-1: Test for coreutils 5.97 bug that was
fixed in coreutils 6.0, and which should still be fixed with
this change.
* tests/mkdir/p-3: Likewise.
2006-09-16 20:03:56 +00:00
Jim Meyering adbad7626c * Makefile.maint (sc_require_config_h, sc_prohibit_assert_without_use):
Discard stdout from the new use of grep.
2006-09-16 08:44:18 +00:00
Jim Meyering f944211020 * bootstrap.conf (gnulib_modules): Add rename-dest-slash.
The 2006-09-08 changes made it so "mv dir new-name/" would
fail on NetBSD 1.6.  This makes it work once again.
2006-09-15 14:11:39 +00:00
Jim Meyering 32d83cf587 * src/mv.c (main): Remove unnecessary (always-true) test for 2 <= n.
Instead, since it's a little fragile, assert the condition.
(target_directory_operand): Update comment to reflect latest change.
2006-09-14 10:06:42 +00:00
Paul Eggert 33f1b50fca (print_user): Rewrite to avoid warning from GCC 4.1.1 with -Wall. 2006-09-12 23:32:16 +00:00
Jim Meyering e1fb2a80bb * tests/mv/atomic: Check for specific strace output, rather than
simply nonempty.  RHEL AS 4 would fail this test due to strace
generating "[ Process PID=14434 runs in 32 bit mode. ]".
Reported by Nelson Beebe.
2006-09-12 09:33:40 +00:00
Jim Meyering fb15bc880a * src/c99-to-c89.diff: Add another set of curly braces. 2006-09-11 13:56:15 +00:00
Jim Meyering 75b99e8f20 * src/remove.c (remove_dir): Move new cache_stat_init call onto
it's own line.
(rm_1): Move declaration of "st" and new cache_stat_init call
"down" to nearer where they're used.
2006-09-11 13:22:04 +00:00
Paul Eggert d28b0d4de8 (eval6): Fix buffer overrun, or bad performance, if
substr's last operand is very large.  Performance problem reported
by Sebastian Kreft.
2006-09-11 04:56:43 +00:00
Jim Meyering 6f2530cf3a * Makefile.maint (sc_prohibit_assert_without_use): Likewise. 2006-09-09 16:18:57 +00:00
Jim Meyering 77d7a11b2f * Makefile.maint (sc_require_config_h): Skip this test if there are no version-
controlled .c files.
2006-09-09 15:58:36 +00:00
Jim Meyering cc29b366aa * Makefile.maint (sc_prohibit_jm_in_m4): Don't hang when there
are no .m4 files.
2006-09-09 14:59:11 +00:00
Jim Meyering 262296271d * bootstrap: Export CVS_RSH separate from its assignment, to work
even with Solaris 10's /bin/sh.  Suggestion from Mark D. Baushke.
2006-09-08 19:28:46 +00:00
Paul Eggert 5c81574ed5 tail now ignores the -f option if POSIXLY_CORRECT is set,
no file operand is given, and standard input is any FIFO.
2006-09-08 17:19:51 +00:00
Jim Meyering d7619b5fe8 mv and "cp -r" no longer fail when invoked with two arguments
where the first one names a directory and the second name ends in
a slash and doesn't exist.  E.g., "mv dir B/", for nonexistent B,
now succeeds, once more. This reverts part of the 2004-06-27
change for 5.3.0.
* NEWS: Say the above.
* src/mv.c (target_directory_operand): Don't require (here)
that the target operand "look like" a directory.  This change
pushes the test down to the rename syscall level, where a
"mv dir existing-non-dir/" will mistakenly succeed on older systems
that ignore trailing slashes in the rename destination argument.
* src/cp.c (target_directory_operand): Likewise, but for cp.
* tests/mv/trailing-slash: Exercise the above fixes.
* tests/cp/trailing-slash: New file.
* tests/cp/Makefile.am (EXTRA_DIST): Add trailing-slash.
2006-09-08 17:08:53 +00:00
Jim Meyering fc1e25cfa5 * bootstrap: Use the previously unused variable, $src,
to avoid repeating "$GNULIB_SRCDIR/$file".
2006-09-08 08:59:31 +00:00
Jim Meyering 926e64e021 * bootstrap (cp_mark_as_generated): Don't use "local", to
accommodate ancient "/bin/sh".  Suggested by Ralf Wildenhues.
Rename now-global "$src" and "$dst" to have cp_ prefix.
Safer, and avoids confusion.
2006-09-08 08:57:45 +00:00
Jim Meyering c4e65d56c1 * bootstrap: Fix last-minute typo. 2006-09-08 08:01:17 +00:00
Jim Meyering 80799ead41 * bootstrap (cp_mark_as_generated): Don't add C-style comments for .l or .y files. 2006-09-08 07:57:21 +00:00
Jim Meyering af2c5a4ab0 * bootstrap (cp_mark_as_generated): New function.
(slurp): Use it to prepend editor hints and a warning that
the file we're copying is generated.
Suggestion from Bruce Korb.
2006-09-08 06:52:24 +00:00
Jim Meyering a3ebb3f3d1 * bootstrap: Revert last change. There are less disruptive ways
to mark these generated files as read-only.
2006-09-07 21:00:58 +00:00
Jim Meyering 0212b962b4 * src/c99-to-c89.diff: Update to have proper offsets. 2006-09-07 09:21:00 +00:00
Jim Meyering 36422ec95c Ensure that some gnulib-tool-generated files are read-only.
* bootstrap (slurp): Put the body of this function in a sub-shell,
with "umask a-w" so that all new files are read-only.  Remove each
file before we write to it, in case it's read-only.
Make po/Makevars and runtime-po/Makevars read-only, too.
2006-09-06 22:00:15 +00:00
Jim Meyering ef2071bc67 * tests/cp/acl: Skip this test when cp lacks ACL support.
* tests/cp/Makefile.am (TESTS_ENVIRONMENT): Set $(CONFIG_HEADER).
2006-09-05 11:50:56 +00:00
Jim Meyering fe99a4f8c8 * src/c99-to-c89.diff (remove.c): Adapt one hunk to match the new
context from change of 2006-09-02.
2006-09-05 11:12:06 +00:00
Jim Meyering ce5b2a6ec4 * README-cvs: Fix typo in update command. 2006-09-04 07:44:56 +00:00
Jim Meyering 5e451b260f * NEWS: Tweak the wording in the new change description so that
no one can think this change causes e.g., `rm -fr foo../' to fail.
2006-09-03 20:16:38 +00:00
Jim Meyering fbb234c2a7 Use $CONFIG_HEADER, rather than hard-coding it.
* tests/rm/Makefile.am (TESTS_ENVIRONMENT): Set $CONFIG_HEADER.
2006-09-03 07:22:08 +00:00
Jim Meyering 31ca1f9aec * tests/rm/inaccessible: Adjust for movement of config.h to lib/. 2006-09-03 07:18:52 +00:00
Paul Eggert ae325b5b97 rm now rejects attempts to remove /, ./, and ../. 2006-09-03 02:56:51 +00:00
Paul Eggert 93c30a24c4 * m4/jm-macros.m4 (gl_MACROS): Call cu_PREREQ_STAT_PROG rather
than AC_REQUIREing, so that sys/mount.h isn't tested for after
the test result.  I'm not sure why this fix is needed, but it
works.
* m4/stat-prog.m4 (cu_PREREQ_STAT_PROG): Revamp to reflect better
what stat.c actually needs.
* src/stat.c: Include <stddef.h>
(alignof): New macro.
(HAVE_STRUCT_STATXFS_F_FSID___VAL, HAVE_STRUCT_STATXFS_F_FSID_VAL):
Remove.
(STRUCT_STATXFS_F_FSID_IS_INTEGER): New macro.
(FSID_VAL): Remove.
(print_statfs): If f_fsid isn't an integer, grab its words one
at a time in little-endian order.  This is a bit easier to configure
and should avoid a compilation failure on MacOS reported by Bruno
Haible.
2006-09-01 19:40:46 +00:00
Paul Eggert ddb97ab3b1 * src/stat.c (HAVE_STRUCT_STATXFS_F_FSID_VAL, FSID_VAL): New macros, to
work around a Mac OS X porting problem reported by Bruno Haible in
<http://lists.gnu.org/archive/html/bug-coreutils/2006-08/msg00308.html>.
(print_statfs): Use them.
* m4/stat-prog.m4 (cu_PREREQ_STAT_PROG): Check for __val versus val
components of fsid.  Omit some checks that stat.c doesn't care about.
2006-08-29 21:53:29 +00:00
Paul Eggert bc7aa2329c * bootstrap.conf (gnulib_modules): Add isapipe.
* src/tail.c: Include isapipe.h.
(IS_PIPE_LIKE_FILE_TYPE): Remove.
(IS_TAILABLE_FILE_TYPE): Just list both FIFOs and sockets as
tailable, since this seems to be portable.
(main): Use isapipe, to fix a bug on MacOS X reported by Bruno Haible in
<http://lists.gnu.org/archive/html/bug-coreutils/2006-08/msg00304.html>.
2006-08-29 20:50:21 +00:00
Paul Eggert 1b6b9ac6ee * src/system.h (LOCALEDIR): Remove, since configmake.h now defines
it for us.
2006-08-29 14:26:52 +00:00
Paul Eggert 1b8c1afd70 (main): Don't test whether macros like
S_ISLNK are defined, since they're always defined now.
2006-08-29 00:32:33 +00:00
Paul Eggert 25aebae77d * src/copy.c (copy_internal): Don't test whether macros like
S_ISLNK are defined, since they're always defined now.
* src/cp.c (main): Likewise.
* src/ln.c (main): Likewise.
* src/ls.c (get_link_name, make_link_name): Likewise.
* src/mkfifo.c (usage): Likewise.
* src/who.c (S_IWGRP): Likewise.
2006-08-28 23:29:38 +00:00
Paul Eggert 023c88aaa0 Adjust to recent gnulib changes for the gnulib module.
* bootstrap.conf (gnulib_modules): Add fcntl.
* src/system.h (SEEK_SET, SEEK_CUR, SEEK_END): Remove.  Other code
is already assuming these macros are defined.
(O_DIRECT, O_DIRECTORY, O_DSYNC, O_NDELAY, O_NOATIME, O_NONBLOCK):
(O_NOCTTY, O_NOFOLLOW, O_NOLINKS, O_RSYNC, O_SYNC, O_BINARY, O_TEXT):
Remove; the fcntl module now handles these.
2006-08-28 23:05:13 +00:00
Paul Eggert a66840f18d Adjust to recent gnulib changes for the inttypes module.
* bootstrap.conf (gnulib_modules): Remove stdint; add inttypes.
(excluded_files): Don't exclude m4/inttypes-h.m4 or m4/inttypes-pri.m4.
* src/system.h: Don't bother to include <stdint.h>, since we can
now assume inttypes.h does the equivalent of including stdint.h.
2006-08-28 20:51:56 +00:00
Jim Meyering ba663fc190 Use http://, not https:// for savannah.gnu.org bug URLs. 2006-08-27 19:59:15 +00:00
Jim Meyering e7573e15d9 * NEWS: Mention this. 2006-08-27 19:46:26 +00:00
Jim Meyering 520a954d7e * src/copy.c (copy_internal): Don't make a backup if the last
component of the source name is "." or "..".
Reported by Andreas Schwab in https://savannah.gnu.org/bugs/?17540.
* tests/cp/src-base-dot: New file.  Test for the above fix.
* tests/cp/Makefile.am (TESTS): Add src-base-dot.
2006-08-27 19:41:04 +00:00
Jim Meyering 0744662509 * src/system.h (DOT_OR_DOTDOT): Remove macro. Rewrite as a...
(dot_or_dotdot): ...new static inline function.
* src/remove.c (rm_1): Reflect this renaming.
* src/ls.c (basename_is_dot_or_dotdot): Likewise.
2006-08-27 19:34:28 +00:00
Jim Meyering 7f535c46a6 * src/copy.c (copy_internal): Add comments. 2006-08-27 16:20:52 +00:00
Paul Eggert ddf6238830 (AM_CPPFLAGS): Remove -I$(srcdir) and -I../lib,
since Automake supplies them for us.  It always did -I$(srcdir),
and with the recent change to AC_CONFIG_HEADERS in configure.ac it
is now also doing -I../lib.
2006-08-27 06:03:02 +00:00
Paul Eggert bc94006bd5 Fix typo in previous bootstrap change; WGET_COMMAND is needed by sh. 2006-08-27 03:35:09 +00:00
Jim Meyering e9bf9a6ecc This test was failing in some environments.
* tests/ls/color-dtype-dir: Don't rely on eval "`dircolors -b`"
to set LS_COLORS in the environment.
* tests/envvar-check: Instead, ensure that LS_COLORS is not set.
Reported by Bob Proulx.
2006-08-26 18:44:52 +00:00
Paul Eggert 2ace7e1eee * bootstrap (get_translations): Skip this if WGET_COMMAND is empty.
Fail if the first "echo" fails.  Suppress diagnostics from "ls po/*.po"
since there might not be any .po files.
(WGET_COMMAND): Set to empty if wget doesn't
seem to be available.  Don't export; shouldn't be needed.
2006-08-26 18:33:08 +00:00
Jim Meyering fd52fdf603 * tests/mv/Makefile.am (TESTS): Add backup-dir. 2006-08-26 17:13:49 +00:00
Jim Meyering 96940eb05b * src/c99-to-c89.diff: Remove hunk for copy.c; no longer needed. 2006-08-26 16:21:15 +00:00