Commit Graph
199 Commits
Author SHA1 Message Date
Jim Meyering 0c2d21d3f2 * src/csplit.c (usage): Use two spaces (not one) to separate
each option string from its description, so help2man formats
the derived man page properly.  Reported by Thomas Huriaux in
<http://bugs.debian.org/410407>.
* src/df.c (usage): Likewise.
* src/du.c (usage): Likewise.
* src/install.c (usage): Likewise.
* src/ls.c (usage): Likewise.
2007-02-10 16:15:34 +01:00
Paul Eggert 8406e92795 install.c: Preserve time stamps before changing owner or file mode bits,
for consistency with other coreutils programs.
2006-12-04 10:06:11 +01:00
Paul Eggert dc52b433ef * src/install.c (make_ancestor): New arg COMPONENT.
* src/mkdir.c (make_ancestor): Likewise.
* tests/install/basic-1: Check for install -Dv bug.
2006-10-07 07:08:29 +00:00
Paul Eggert 4767fc607e Fix bug reported today by Mike Frysinger: mkdir -pv is logging the
wrong file name in some cases.
* src/install.c (struct install_options): New type.
(install_file_in_file_parents, main):
Use it instead of struct cp_options.
(process_dir): Remember the full name.
(announce_mkdir, make_ancestor): Use the full name in announcements.
* src/mkdir.c (struct mkdir_options): Add full_name member.
(make_ancestor): Use the full name in announcements.
(process_dir): Remember the full name.
* tests/mkdir/Makefile.am (TESTS): Add p-v.
* tests/mkdir/p-v: New file, to test this bug.
2006-10-06 20:44:31 +00:00
Paul Eggert b67faf329c * NEWS: Document that mkdir -p and install -d now fork on occasion.
* bootstrap.conf (gnulib_modules): Add savewd.
* src/install.c: Include savewd.h.
(process_dir): New function.
(main, install_file_in_file_parents): Use it, along with the new
savewd module, to avoid some race conditions.
* src/mkdir.c: Include savewd.h.
(struct mkdir_options): New members make_ancestor_function, mode,
mode_bits.
(make_ancestor): Return 1 if the resulting directory is not readable.
(process_dir): New function.
(main): Use it, along with new savewd module, to avoid some
race conditions.  Fill in new slots of struct mkdir_options, so
that callees get the values.
* tests/install/basic-1: Test for coreutils 5.97 bug that was
fixed in coreutils 6.0, and which should still be fixed with
this change.
* tests/mkdir/p-3: Likewise.
2006-09-16 20:03:56 +00:00
Paul Eggert d8049d7478 Don't include dirname.h, since system.h does it now. 2006-09-03 02:53:16 +00:00
Paul Eggert 83978a5654 Include mkancesdirs.h.
(announce_mkdir, make_ancestor): New functions.
(DEFAULT_MODE): New macro, specifying initial value of 'mode'.
(mode): Use it.
(dir_mode, dir_mode_bits): New vars.
(main): Set dir modes separately from nondir, so that the X
op of -m works correctly.
(main): Remove cwd_errno cruft, since make_dir_parents no longer
affects cwd.  Adjust to new make_dir_parents API.
(install_file_in_file_parents): 2nd arg is now char *, not char
const *.  Use mkancesdirs instead of rolling our own code.
(change_attributes): Don't worry about AFS, since that kludge
should not be needed any more.
2006-07-17 03:09:49 +00:00
Jim Meyering 9c3afb4a64 (target_directory_operand, install_file_in_dir): Use new last_component, in place of base_name. 2006-03-26 12:06:45 +00:00
Jim Meyering e7771c1161 (usage): Use two spaces (not one) to separate the
--first-only option string from its description, so help2man formats
the derived man page properly.
2006-02-18 07:23:05 +00:00
Jim Meyering 7b08fdb1eb (cp_option_init): Don't set umask_kill member. 2005-12-17 10:46:23 +00:00
Paul Eggert 8e4680db2f (install_file_in_file): Be more conservative about the previous patch:
set time stamps on all non-regular files.
2005-09-23 20:50:49 +00:00
Paul Eggert 63b77aac44 (change_timestamps): First arg is source
struct stat, not file name.  All uses changed.
(install_file_in_file): Stat the source file if necessary.
Don't try to change time stamps if copy_file did it.
2005-09-23 20:39:04 +00:00
Paul Eggert 158d982669 Include stat-time.h, and use its functions instead of the obsolete
TIMESPEC_NS macro.
2005-09-16 07:50:33 +00:00
Jim Meyering 74f54dae78 Finally remove support for --version-control=S (-V).
It was deprecated nearly 6 years ago and has been warning
users to switch to --backup=S since fileutils-4.0j.
2005-06-16 09:15:23 +00:00
Jim Meyering ec5b4733d8 (main): Fix my typo: s/argv[optind]/file[i]/. 2005-06-15 08:54:21 +00:00
Paul Eggert 3f47e8458a (main): Standardize on a diagnostic for
restore_cwd failure, and report errno.
(install_file_in_file_parents): Fail if restore_cwd fails and
one of the files is relative.  This fixes a bug (albeit unlikely).
2005-06-14 23:55:24 +00:00
Paul Eggert 7cc0d42200 (main): Adjust to new make_dir_parents convention. 2005-06-14 18:35:58 +00:00
Jim Meyering 19c47583a2 tweak diagnostic wording: Use `... return to working directory', rather
than `... restore working directory'.
2005-06-14 08:18:43 +00:00
Jim Meyering 6000585c85 remove obsolete FIXME 2005-06-14 07:55:32 +00:00
Jim Meyering 736dfd391d (main): When make_dir_parents changes the current working
directory, give a diagnostic about each subsequent failure to create
a dot-relative directory.
(install_file_in_file_parents): Update make_dir_parents caller.
2005-06-13 10:19:18 +00:00
Paul Eggert 55b579a133 Don't use "path" or "filename".
(install_file_in_file_parents): Renamed from
install_file_to_path.  All uses changed.
2005-06-02 05:13:29 +00:00
Paul Eggert fe34f6c28d (cp_options_init): Use chown_privileges rather than geteuid. 2005-05-31 06:16:09 +00:00
Paul Eggert 003510fda2 (getpwnam, getgrnam): Remove decl.
(getuid, getgid) [!defined _POSIX_VERSION]: Remove decls.
2005-05-30 07:33:16 +00:00
Jim Meyering 44d59bb168 Update FSF postal mail address. 2005-05-14 07:58:31 +00:00
Jim Meyering c0c815af8d Update FSF postal mail address. 2005-05-14 06:57:06 +00:00
Paul Eggert 71a7e54b0d mode_free -> free 2005-05-01 14:27:51 +00:00
Paul Eggert b1fdaf5ac7 (main): Adjust to new modechange API.
Also, free the mode_change object when done.
2005-04-28 16:31:09 +00:00
Paul Eggert cef32c7c86 (stat): Remove decl. 2004-11-26 07:39:32 +00:00
Paul Eggert c0b70ba29b (usage): Avoid usage that runs afoul of Docbook
translation.  Problem reported by Eric S. Raymond.
2004-11-21 07:29:31 +00:00
Paul Eggert 81ca57a91d Remove unused "case 0". 2004-09-21 22:26:42 +00:00
Paul Eggert 3e60f6731d Adjust to backup file rename. 2004-09-13 12:13:04 +00:00
Paul Eggert f469551274 Further fix for -d regression. 2004-08-11 23:41:44 +00:00
Paul Eggert b2c632e20c (main): Fix -d regression introduced with
--target-directory support at 2004-06-25.
2004-08-11 21:44:36 +00:00
Paul Eggert 811c61b049 (change_timestamps): Fix int->bool conversion
bugs introduced on 2004-07-29.
2004-08-10 20:32:19 +00:00
Paul Eggert 1dfc8b472e (isdir): Remove decl.
(install_file_to_path): Rely on make_path to fail if the destination
is not a directory, by passing preserve_existing==true to it.
Hence we no longer need to call isdir.
Free dest_dir immediately when it's no longer needed, rather than
waiting until the end of the function.
(copy_file): Don't bother calling isdir, as copy will do the
right thing if the destination is a directory.
2004-08-02 20:14:39 +00:00
Paul Eggert 0892ed97a6 (isdir, change_timestamps, change_attributes,
copy_file, install_file_to_path, install_file_in_dir,
install_file_in_file, strip_files, dir_arg, cp_option_init, main,
change_attributes, change_timestamps): Likewise.
2004-07-30 07:57:50 +00:00
Jim Meyering 9f3628bd45 Add short names -t and -T for --target-directory
and --no-target-directory options, respectively.

(NO_TARGET_DIRECTORY_OPTION, TARGET_DIRECTORY_OPTION):
Remove.  All uses changed to 'T' and 't', respectively.

(long_options, main, usage): Add -t and -T as
aliases for --target-directory and --no-target-directory,
respectively.
2004-07-02 17:00:53 +00:00
Jim Meyering ba039472a8 Add support for --no-target-directory option.
(NO_TARGET_DIRECTORY_OPTION): New constant.
(long_options, usage, main): Add support for
2004-06-30 18:40:40 +00:00
Jim Meyering 0ec60860b6 Add support for 'install --target-directory', an option
that has been documented for years but not implemented (!).

(TARGET_DIRECTORY_OPTION): New var.
(long_options, main, usage): Add --target-directory.
(target_directory_operand): New function, stolen from mv.c.
(main): Use it.  Check for -d and --target-directory.
Alter wording of diagnostics to match other programs.
2004-06-29 14:40:47 +00:00
Jim Meyering 1ce7b61d0e (main): Standardize on the diagnostics given when someone gives
too few operands ("missing operand after `xxx'") or
too many operands ("extra operand `xxx'").
Include "quote.h" and/or "error.h" if it wasn't already being included.
2004-06-21 15:03:35 +00:00
Jim Meyering 4441496397 install -s failed on System V if SIGCHLD was ignored.
Include <signal.h>.
(main) [defined SIGCHLD]: Set SIGCHLD handler to the default,
if -s is given, since System V fork+wait does not work if SIGCHLD
is ignored.
2004-04-21 12:25:18 +00:00
Jim Meyering ad31f43350 (cp_option_init): Likewise. 2004-02-07 16:01:31 +00:00
Jim Meyering f56bc12872 (usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
2004-01-21 23:14:46 +00:00
Jim Meyering cf4fdf373f Most .c files (AUTHORS): Revert the WRITTEN_BY/AUTHORS change
of 2003-09-19.  Now, AUTHORS is a comma-separated list of strings.
Update the call to parse_long_options so that `AUTHORS, NULL' are the
last parameters.

* src/true.c (main): Append NULL to version_etc argument list.
* src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
2003-10-18 10:05:47 +00:00
Jim Meyering bafd927f03 (WRITTEN_BY): Rename from AUTHORS.
Begin each WRITTEN_BY string with `Written by ' and end it with `.'.
Mark each WRITTEN_BY string as translatable.
2003-09-18 22:19:03 +00:00
Jim Meyering c9df366ee5 Include utimens.h.
(change_timestamps): Set file timestamps with utimens, not utime.
2003-08-09 17:47:34 +00:00
Jim Meyering 64521cfa9a It appears that the `#pragma alloca' included via "system.h" is
adequate, since join.c uses alloca, yet lacked an in-file #pragma.

Remove `#pragma alloca'.
2003-07-12 11:38:43 +00:00
Jim Meyering 1dae2a560a (change_attributes): Enclose diagnostic in _(...). 2003-07-11 11:10:53 +00:00
Jim Meyering 6bcd4b08ba (main): Call initialize_main. 2003-06-17 18:13:23 +00:00
Jim Meyering 8eb2464d3e (main): Handle argc < optind. 2003-05-10 14:33:24 +00:00