Commit Graph
4065 Commits
Author SHA1 Message Date
Jim Meyering 6ffc95a9e3 (ADD_RANGE_PAIR): Use x2nrealloc rather than xrealloc,
to avoid potential overflow in pointer arithmetic.
(set_fields): Use not `1', but rather `sizeof *printable_field' as
second argument to xcalloc.
2003-11-04 06:28:01 +00:00
Jim Meyering 26809f0450 (next_file_name): Use `sizeof *var' rather than
hard-coding `sizeof size_t'.
2003-11-04 06:25:45 +00:00
Jim Meyering 11e97f430c (AUTHORS): Add my name. 2003-11-04 06:21:03 +00:00
Jim Meyering 45240f2481 (main): Use sizeof *var' rather than sizeof EXPLICIT_TYPE'.
The former is more maintainable and usually shorter.
2003-11-04 06:13:55 +00:00
Jim Meyering d63bdf9a4d (initseq, add_field, make_blank): Use `sizeof *var' rather
than `sizeof EXPLICIT_TYPE'.
The former is more maintainable and usually shorter.
2003-11-04 06:07:01 +00:00
Jim Meyering 9c76808b89 (alloc_and_compile_regex, main): Use `sizeof *var' rather
than `sizeof EXPLICIT_TYPE'.
The former is more maintainable and usually shorter.
2003-11-02 20:39:26 +00:00
Jim Meyering 0abb38e587 (new_item, record_relation): Use `sizeof *var' rather
than `sizeof EXPLICIT_TYPE'.
The former is more maintainable and usually shorter.
2003-11-02 20:24:14 +00:00
Jim Meyering 55760c106b (add_fs_type, add_excluded_fs_type, main): Use `sizeof *var' rather
than `sizeof EXPLICIT_TYPE'.
The former is more maintainable and usually shorter.
(main): Also remove anachronistic cast of xmalloc return value.
2003-11-02 20:22:54 +00:00
Jim Meyering e5dda0ab93 (make_path_private): Use sizeof *var' rather than sizeof EXPLICIT_TYPE'.
The former is more maintainable and usually shorter.
2003-11-02 20:17:46 +00:00
Jim Meyering 4265d0095e (copy_internal): Use sizeof *var' rather than sizeof EXPLICIT_TYPE'.
The former is more maintainable and usually shorter.
2003-11-02 20:17:04 +00:00
Jim Meyering 08fd60e693 (inittables): Use sizeof *var' rather than sizeof EXPLICIT_TYPE'.
The former is more maintainable and usually shorter.
(sort): Split a long line.
2003-11-02 20:16:19 +00:00
Jim Meyering 108be09181 (append_normal_char, append_range, append_char_class)
(append_repeated_char, append_equiv_class, spec_init): Use more maintainable
and usually-shorter `sizeof *var' rather than `sizeof EXPLICIT_TYPE'.
2003-11-02 19:50:48 +00:00
Jim Meyering fc80caecd8 (triple_hash, triple_hash_no_name): Adjust to reflect
type changes (unsigned int -> size_t) in hash.c.
2003-10-25 15:34:01 +00:00
Jim Meyering 0a875d3d7b (src_to_dest_hash): Adjust to reflect
type changes (unsigned int -> size_t) in hash.c.
2003-10-25 15:33:43 +00:00
Jim Meyering 24a7d395e3 (hash_int): Adjust to reflect
type changes (unsigned int -> size_t) in hash.c.
2003-10-25 15:33:28 +00:00
Jim Meyering c965791d3e (entry_hash): Adjust to reflect
type changes (unsigned int -> size_t) in hash.c.
2003-10-25 15:33:05 +00:00
Jim Meyering b2c8266f8b (dev_ino_hash): Adjust to reflect
type changes (unsigned int -> size_t) in hash.c.
2003-10-25 15:32:07 +00:00
Jim Meyering 96a5d2ce6a chmod now uses fts to perform a directory traversal when -R is
specified.  Before, it operated on full path names, and as such
would encounter the PATH_MAX (often 4096) limit.

Include "xfts.h".
(process_file): Rename from change_file_mode.
Adapt to be used with fts.
(process_files): New function.
2003-10-19 18:54:10 +00:00
Jim Meyering 672f1510e1 . 2003-10-18 10:10:50 +00:00
Jim Meyering cf4fdf373f Most .c files (AUTHORS): Revert the WRITTEN_BY/AUTHORS change
of 2003-09-19.  Now, AUTHORS is a comma-separated list of strings.
Update the call to parse_long_options so that `AUTHORS, NULL' are the
last parameters.

* src/true.c (main): Append NULL to version_etc argument list.
* src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
2003-10-18 10:05:47 +00:00
Jim Meyering f81b126bd4 . 2003-10-18 10:05:08 +00:00
Jim Meyering b729765ba0 (usage): Tweak descriptions of -i and -f so that the
generated `man' page is more readable.  Suggestion from Dan Jacobson.
2003-10-18 05:04:29 +00:00
Jim Meyering 46a137de8d . 2003-10-17 13:50:12 +00:00
Jim Meyering 0c73b9e2c5 (change_file_owner): Handle the cases in
which fts_info indicates an error with the given entry.
2003-10-17 13:37:23 +00:00
Jim Meyering ae7d7b4ad4 (main): Simply assign to bit_flags.
Don't bother with bit arithmetic.
2003-10-17 13:34:46 +00:00
Jim Meyering d0557a6294 Include "xfts.h".
(chown_files): Use xfts_open, rather than fts_open.
2003-10-17 11:12:44 +00:00
Jim Meyering 433a4c3059 Include "xfts.h".
(du_files): Use xfts_open, rather than fts_open.
2003-10-17 11:12:11 +00:00
Jim Meyering 5788d8e9b2 tweak comment 2003-10-17 10:50:13 +00:00
Jim Meyering 1bac4198f2 tweak comment 2003-10-17 10:49:38 +00:00
Jim Meyering 9a35ea11d4 (main): Simply assign to bit_flags.
Don't bother with bit arithmetic.
Rename a couple of local variables.
Remove unnecessary casts.
2003-10-16 07:56:02 +00:00
Jim Meyering 029d5937c4 (main): Simply assign to bit_flags.
Don't bother with bit arithmetic.
2003-10-16 07:51:57 +00:00
Jim Meyering 841cfd35c9 (start_bytes): Rename local, remainder, to avoid
gcc's warning about shadowing a global.
2003-10-16 07:28:01 +00:00
Jim Meyering 1c5ec523a4 . 2003-10-15 21:47:54 +00:00
Jim Meyering 21ed960c0f . 2003-10-15 21:21:42 +00:00
Jim Meyering 0ebfdf25d1 Include "fts_.h".
(WRITTEN_BY): Add my name.
(MAXUID, MAXGID): Remove definitions.  Use GID_T_MAX instead of
the latter.
(usage): Update.
(main): Handle new options.
Call new function, chown_files rather than change_file_owner.
2003-10-15 21:21:29 +00:00
Jim Meyering fe9f5bdf77 chown now accepts POSIX-mandated -H, -L, -P options and uses
fts to perform a directory traversal when -R is specified.
Before, it used explicit recursion, and as such was limited by
the user's stack size to handling hierarchies no deeper than
about 30,000 levels.

Include "userspec.h" and "fts_.h".
(WRITTEN_BY): Add my name.
(getpwnam, getgrnam, getgrgid): Remove declarations.
(endpwent): Remove definition.
(usage): Update
(main): Handle new options.
Call new function, chown_files rather than change_file_owner.
2003-10-15 21:16:46 +00:00
Jim Meyering dcac334f28 [enum Dereference_symlink]: Remove declaration.
[struct Chown_option] (recurse, force_silent): Change type to `bool'.
[struct Chown_option] (dereference): Remove member with ambiguous name.
[struct Chown_option] (affect_symlink_referent): New member.
(chown_files): New prototype.
2003-10-15 13:57:21 +00:00
Jim Meyering 9c81925d00 Rewrite to iterate through hierarchies using fts rather than
via explicit recursion.

Include "fts_.h"
(change_file_owner): Rewrite to use FTS* and FTSENT* and to operate
on a single file at a time.
(chown_files): New function.
2003-10-15 13:56:28 +00:00
Jim Meyering 38f68e78ae (usage): Clarify that --directory, -d, -F probably won't
work even for superuser.  Suggestion from Dan Jacobson.
2003-10-15 07:40:52 +00:00
Jim Meyering a9825dd2a6 (parse_field_count): Handle the case where overflow
and invalid suffix char are both reported.
2003-10-15 07:24:39 +00:00
Jim Meyering 92f4be12b1 (decode_switches) [TIOCGWINSZ]: Comment out the
warning-inducing test, ws.ws_col <= SIZE_MAX, since it was always
true on Linux.
2003-10-14 20:59:50 +00:00
Jim Meyering d7bed21394 Fix to avoid a denial-of-service attack if the display width is
enormous.  Also, clean up the code a bit by removing duplicate code.

(init_column_info): Remove forward decl; no longer needed.
(calculate_columns): New function, that contains code that used
to be common to print_many_per_line and print_horizontal.
(print_many_per_line, print_horizontal): Use it.
(decode_switches): Set max_idx here, not in calculate_columns.
(print_current_files): Don't call init_column_info; calculate_columns
now does that.
(init_column_info): Don't allocate a lot more space than is needed
to represent the current set of files.  Allocate all the new
size_t cells in one call to xnmalloc, rather than a row at a time.
2003-10-14 09:09:43 +00:00
Jim Meyering ae2e1ea1dc (init_column_info): Add another FIXME comment. 2003-10-13 20:50:40 +00:00
Jim Meyering a8e60e65f8 (struct bin_str.len, length_of_file_name_and_frills, indent,
nfiles, files_index, tabsize, line_length, struct column_info.line_len,
struct column_info.col_arr[0], max_idx):
Now size_t, not int.
(get_funky_string): Return bool indicating success, instead of
a negative count to indicate failure.  Store number of columns
through new parameter OUTPUT_COUNT; that way, they can never
go negative.  Change equals_end from int to bool.  All uses
changed.
(struct column_info.valid_len): Now bool, not int.  All uses changed.
(dired_dump_obstack, get_funky_string, clear_files,
extract_dirs_from_files, print_current_files,
print_many_per_line, print_horizontal, init_column_info,
put_indicator, length_of_file_name_and_frills,
print_with_commas): Use size_t, not int, for local variables
that count sizes.
(decode_switches): Decode sizes using xstrtoul, not xstrtol.
Check for TIOCGWINSZ returing negative values (or values greater
than SIZE_MAX!).
(visit_dir, main, parse_ls_color, queue_directory, add_ignore_pattern,
init_column_info):
Use xmalloc and xnmalloc, not XMALLOC.
(gobble_file): Use xnrealloc, not XREALLOC.
(print_color_indicator): Remove now-unnecessary cast to size_t.
2003-10-13 15:16:27 +00:00
Jim Meyering aa615387af (print_many_per_line): Add FIXME comment. 2003-10-13 14:26:50 +00:00
Jim Meyering 9be74f6f12 New options: --preserve-root and --no-preserve-root.
(change_file_mode): Honor new option.
(change_file_mode): Strip trailing slashes on directory
argument passed to change_dir_mode.
(get_root_dev_ino): New function.
(main): Initialize global, root_dev_ino.
2003-10-12 14:19:25 +00:00
Jim Meyering 4a992bfdd8 (change_file_mode): Don't #ifdef-out a simple use of
S_ISLNK.  The S_IS* macros are guaranteed to be defined
via system.h.
2003-10-12 07:05:16 +00:00
Jim Meyering 498de26ac5 (copy_internal): Don't #ifdef-out simple uses of
S_ISLNK or S_ISSOCK.  The S_IS* macros are guaranteed to be defined
via system.h.
2003-10-12 07:03:57 +00:00
Jim Meyering d681c9a662 tweak comments 2003-10-09 08:43:15 +00:00
Jim Meyering 20fd309527 (main): Remove obsolete FIXME. 2003-10-08 18:24:04 +00:00