Commit Graph
4582 Commits
Author SHA1 Message Date
Paul Eggert 609b271cc5 (main): Use bool for booleans. 2004-08-03 06:00:08 +00:00
Paul Eggert b3c28cad1b (show_date, rfc_format, batch_convert, main): Use bool for booleans. 2004-08-03 05:59:36 +00:00
Paul Eggert a982e48ca3 (cut_fields): Use to_uchar rather than a cast.
(cut_file, main): Use bool for booleans.
2004-08-03 05:59:14 +00:00
Paul Eggert 846cb63700 (struct line): Use size_t for sizes.
(main): Remove unnecessary cast.
2004-08-03 05:58:49 +00:00
Paul Eggert c5c1463809 (COST, MAXWORDS): Add a comment describing some of
fmt's arbitrary limits.
(TRUE, FALSE): Remove; all uses changed to (true, false).
(main): Use bool for booleans.
Limit maximum width to MAXCHARS / 2.  Use xstrtoul, not xstrtol,
to parse width.
(copy_rest): Remove unnecessary cast.
(get_prefix): Rewrite to avoid cast.
(check_punctuation): Use char *, not unsigned char *; C89 requires
this.  Avoid off-by-one buffer read overrun when line is empty.
(flush_paragraph): Don't assume wptr-parabuf is <= INT_MAX.
Remove unnecessary casts.
2004-08-03 00:00:49 +00:00
Paul Eggert 71377ec627 (convert_entire_line, have_read_stdin, parse_tabstops,
next_file, expand, main):
Use bool for booleans.
(tab_size, tab_list, add_tabstop, parse_tabstops, validate_tabstops,
expand, main):
Use uintmax_t for column counts.
(add_tabstop): Don't reserve -1 (now UINTMAX_MAX) as a special value.
All callers changed.
(parse_tabstops): Don't pass a negative char to isblank.
Avoid memory leak with large tab stops.
(validate_tabstops, expand): Don't assume number of tab stops is
<= INT_MAX.
(next_file, main): Use EXIT_SUCCESS/EXIT_FAILURE rather than 0/1 when
storing values into exit_status.
(expand): Use same pattern as unexpand for reading chars.
Report an error when input line is too long, instead of silently
screwing up.  Do not mishandle tab stops when backspacing left
over start of line.
2004-08-02 23:49:31 +00:00
Paul Eggert bfaa02d8a9 (have_read_stdin, append_quoted,
dc_parse_stream, dc_parse_file, main): Use bool for booleans.
(dc_parse_stream): Use enum for state, rather than int.
Use ssize_t to store getline result.
2004-08-02 23:36:33 +00:00
Paul Eggert 3bec629dc8 (translation_needed, parse_integer, scanargs,
apply_translations, char_is_saved, swab_buffer, skip_via_lseek):
Use bool for booleans.
(translate_buffer): Use to_uchar rather than a cast.
(swab_buffer, copy_simple, copy_with_unblock):
Use size_t for sizes.
2004-08-02 23:29:39 +00:00
Paul Eggert 2b9bdc6ee0 (struct File_spec, reopen_inaccessible_files, count_lines,
forever, from_start, print_headers, have_read_stdin, valid_file_spec,
write_header, file_lines, pipe_lines, pipe_bytes, recheck,
tail_forever, tail_bytes, tail_lines, tail, tail_file,
parse_obsolescent_option, parse_options, main):
Use bool for booleans.
(struct File_spec, max_n_unchanged_stats_between_opens,
parse_options): Use uintmax_t, not unsigned int or unsigned long int,
for state counters.
(tail_bytes, tail_lines): Redo test of return value (-1, 0, 1) to
make it a bit clearer.
2004-08-02 22:20:24 +00:00
Paul Eggert 9d581705a7 (apply_suffix): Use bool for booleans. 2004-08-02 22:19:27 +00:00
Paul Eggert 76a844a9c3 (equal_width, valid_format, main): Use bool for booleans. 2004-08-02 22:19:01 +00:00
Paul Eggert 98d2fbe280 Include "xgethostname.h".
(xgethostname): Remove decl; xgethostname.h has it.
(sethostname) [!defined(HAVE_SETHOSTNAME) && defined(HAVE_SYSINFO)
&& defined (HAVE_SYS_SYSTEMINFO_H) && defined(HAVE_LIMITS_H)]: Use
prototypes rather than K&R form.  Assume any negative value from
sysinfo denotes failure, not just -1.
(main): Simplify use of sethostname.
2004-08-02 21:52:28 +00:00
Paul Eggert d0cbf9ff71 (do_lookup, short_list, short_output, include_idle,
include_heading, include_mesg, include_exit, need_boottime,
need_deadprocs, need_login, need_initspawn, need_clockchange,
need_runlevel, need_users, my_line_only, main): Use bool for booleans.
(print_runlevel): Use unsigned char for bytes.
(list_entries_who, scan_entries, who): Use size_t for sizes.
(main): No need to pass a non-NULL last arg to getopt_long.
2004-08-02 20:56:46 +00:00
Paul Eggert 889b25b472 (list_entries_users, users): Use size_t for sizes.
(list_entries_users): Use char for bytes.
(main): No need to pass a non-NULL last arg to getopt_long.
2004-08-02 20:56:30 +00:00
Paul Eggert 67f5163d28 (print_uptime, uptime): Use size_t for sizes.
(print_uptime): Remove unused local variable.
(main): No need to pass a non-NULL last arg to getopt_long.
2004-08-02 20:56:10 +00:00
Paul Eggert ea81db5369 (include_idle, include_heading, include_fullname,
include_project, include_plan, include_home_and_shell, do_short_format,
include_where, main): Use bool for booleans.
(count_ampersands, create_fullname, scan_entries, short_pinky):
Use size_t for sizes.
(create_fullname): Check for overflow in size calculations.
(idle_string): Don't assume that the number of idle days
is less than 10**8 and/or INT_MAX/(24*60*60).
(main): No need to pass a non-NULL last arg to getopt_long.
2004-08-02 20:55:44 +00:00
Paul Eggert 1dfc8b472e (isdir): Remove decl.
(install_file_to_path): Rely on make_path to fail if the destination
is not a directory, by passing preserve_existing==true to it.
Hence we no longer need to call isdir.
Free dest_dir immediately when it's no longer needed, rather than
waiting until the end of the function.
(copy_file): Don't bother calling isdir, as copy will do the
right thing if the destination is a directory.
2004-08-02 20:14:39 +00:00
Paul Eggert e4d5fc2283 (fts_debug, opt_all, apparent_size, opt_count_all,
print_grand_total, opt_separate_dirs, hash_ins, process_file, main):
Use bool for booleans.
(max_depth): Now size_t, not int, to avoid an arbitrary limit
of INT_MAX on depth.
(G_fail): Remove: no longer needed, now that the relevant
functions return bool.
(process_file): Use return value to signal success rather than
setting a global.  Remove first_call static var; not needed, since
we can look at n_alloc.  Use size_t for depths.  Remove FIXME
about size_t casts, as it's now fixed.  Use xnrealloc rather
than the obsolescent XREALLOC.  Don't bother to check whether
reallocation is needed unless level > prev_level.
(du_files): Invert sense of result, for consistency with
other coreutils code.  All callers changed.
(main): Allow --max-depth values up to SIZE_MAX.
2004-08-02 19:43:38 +00:00
Paul Eggert 2f9bb99f37 (inode_format, show_all_fs, show_local_fs,
show_listed_fs, posix_format, require_sync, print_type,
selected_fstype, excluded_fstype, show_dev, show_point, main):
Use bool for booleans.
(df_readable, show_dev): Use UINTMAX_MAX instead of -1.
(show_dev, show_point, main):
Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
Don't assume disk name lengths are <= INT_MAX.
Rewrite pct calculation to avoid cast.
(show_point): Don't assume resolved length is <= SSIZE_MAX.
2004-08-02 18:43:35 +00:00
Paul Eggert 09e6455c57 Regenerate. 2004-08-02 05:30:48 +00:00
Paul Eggert 08eeecbbbb (ptr_align): Use size_t; in practice, this is just as
good as uintptr_t in checking for alignments, and has fewer
configuration hassles.
2004-08-02 05:26:19 +00:00
Paul Eggert 45e8d9f87b (UINT_MAX_32_BITS): Remove.
(word32): Remove.  All uses changed to uint32_t.
(isaac_seed_data): Remove unnecessary cast.
2004-08-02 05:26:01 +00:00
Paul Eggert 2c223a305b (hash_int) [!defined UINTPTR_MAX]: Use size_t instead of uintptr_t. 2004-08-02 05:25:33 +00:00
Paul Eggert bb1e87735e (localedir.h): Make it readonly; this
undoes part of the 2004-07-27 patch.
2004-08-01 15:18:29 +00:00
Paul Eggert 94732c8a71 Improve comment for first_same_file. 2004-07-30 23:24:03 +00:00
Paul Eggert 7eb95094d3 (to_uchar): Remove; now in system.h.
(is_char_class_member): Use bool when appropriate.
2004-07-30 21:08:48 +00:00
Paul Eggert 67bfd37c8b (errno, CHAR_BIT): Remove decls;
no longer needed now we assume C89 or better.
Include <inttypes.h> before <stdint.h>, as it's the Autoconf-recommended pattern.
(to_uchar): New inline function, moved here from tr.c.
Use full names for int types, e.g. "long int" rather than "long".
2004-07-30 21:08:25 +00:00
Paul Eggert 9023219a73 (UCHAR): Remove; all uses changed to to_uchar.
(IS_THOUSANDS_SEP): Use bool when appropriate.
(numcompare, main): Use char, not int, when the value is always a char.
(numcompare): Remove "register"; compilers are smart enough these days.
2004-07-30 21:08:02 +00:00
Paul Eggert 5c53a006eb (create_parents, main): Use bool when appropriate.
(main): Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
2004-07-30 20:29:29 +00:00
Paul Eggert a586795939 (main): Use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1. 2004-07-30 08:00:40 +00:00
Paul Eggert 35c0c98c7d (right_justify), full_filename_, AD_pop_and_chdir,
AD_push, prompt, remove_dir): Use bool when appropriate.
(top_dir, pop_dir, full_filename_):
Use size_t for sizes.
2004-07-30 08:00:02 +00:00
Paul Eggert aed86808d9 (rm_option_init, main): Use bool when appropriate.
(main): Use EXIT_SUCCESS, EXIT_FAILURE instead of 0, 1.
2004-07-30 07:59:19 +00:00
Paul Eggert bbed0ba2e3 (remove_trailing_slashes, rm_option_init,
cp_option_init, do_move, movefile, main): Likewise.
* src/remove.c (right_justify), full_filename_, AD_pop_and_chdir,
AD_push, prompt, remove_dir): Likewise.
2004-07-30 07:58:07 +00:00
Paul Eggert 0892ed97a6 (isdir, change_timestamps, change_attributes,
copy_file, install_file_to_path, install_file_in_dir,
install_file_in_file, strip_files, dir_arg, cp_option_init, main,
change_attributes, change_timestamps): Likewise.
2004-07-30 07:57:50 +00:00
Paul Eggert f3b9ba46f8 (struct dir_attr, flag_path, remove_trailing_slashes,
re_protect, make_path_private, target_directory_operand, do_copy,
cp_option_init, decode_preserve_arg, main): Use bool when appropriate.
(target_directory_operand): Do not clear *NEW_DST if stat
succeeds.  It's not necessary in that case, as *NEW_DST is always
false already.
(do_copy): Rewrite slightly to avoid need for "unreachable" comment.
(main): Use EXIT_SUCCESS, EXIT_FAILURE instead of 0, 1.
2004-07-30 07:57:27 +00:00
Paul Eggert 89c5dddb8f (remember_created): Use bool when appropriate. 2004-07-30 07:55:59 +00:00
Paul Eggert 1c9f7316d2 (remember_created): Use bool when appropriate. 2004-07-30 07:55:33 +00:00
Paul Eggert 49eaeaf611 (copy_internal, is_ancestor, copy_dir, copy_reg,
same_file_ok, seen_file, copy_internal, valid_options, copy):
Use bool when appropriate.
2004-07-30 07:51:59 +00:00
Paul Eggert dabfc733f7 (struct cp_options): Use bool when appropriate. 2004-07-30 07:49:39 +00:00
Paul Eggert e61348619a (hard_LC_COLLATE, only_file_1, only_file_2, both, compare_files, main):
Use bool when appropriate.
2004-07-30 05:25:17 +00:00
Paul Eggert 299d98cfe2 (cksum, main): Use bool when appropriate. 2004-07-30 04:12:25 +00:00
Paul Eggert f232dfa081 (recurse, force_silent, process_file, process_files, main): Use bool
when appropriate.
2004-07-30 04:06:41 +00:00
Paul Eggert 577caa4da2 (OPENOPTS, have_read_stdin, status_only, warn,
bsd_split_3, split_3, hex_digits, digest_file, digest_check, main):
Use bool when appropriate.
(digest_check): Increase limit of number of input lines to
UINTMAX_MAX from INT_MAX.  Diagnose any overflows of this counter.
Use ngettext instead of hard-to-i18nize hardcoded stuff for plurals.
2004-07-30 00:54:44 +00:00
Paul Eggert bd20ce2bad Don't include any files other than checksum.h. 2004-07-30 00:54:02 +00:00
Paul Eggert 286aff1fe6 Don't include config.h, sys/types.h, stdio.h: not needed.
(ALG_UNSPECIFIED): Remove.
(ALG_MDT): Don't make it equal to CHAR_MAX + 1; this isn't necessary.
2004-07-30 00:53:49 +00:00
Paul Eggert 69da9561c7 (exit_status): Remove. Now done by passing a boolean
'ok' flag around.
(simple_cat, cat): Return true if successful.  All callers changed.
(simple_cat, cat, main): Use bool for booleans.
(simple_cat): Use size_t for sizes.
(cat, main): Use the same names for parameters that we use for
long options, to avoid confusion.  This inverts the sense of the
show_tabs (formerly output_tabs) and number_nonblank
(formerly numbers_at_empty_lines) variables.
(main): Don't mess up (due to integer overflow) if we are given
INT_MAX - INT_MIN + 1 options.
[O_BINARY]: Don't invoke isatty unless the other options require it.
(main): When deciding whether to use simple_cat, don't worry
about binary option; it's irrelevant.
2004-07-29 06:12:27 +00:00
Paul Eggert 488905a239 Remove comments, trailing white space, and empty
lines from the output strings, to save space.
Use a narrower type like 'unsigned char' for line lengths, if
that will do.
Make the output variables static, not extern.
2004-07-28 23:59:11 +00:00
Paul Eggert d73c456b2e (chown_files): Return true/false, not 0/-1, since we don't set errno. 2004-07-28 23:38:36 +00:00
Paul Eggert 5c0ca7ea76 Include inttostr.h.
(UINT_MAX_DECIMAL_DIGITS, uint_to_string): Remove.
(gid_to_name, uid_to_name): Use imaxtostr/umaxtostr
instead of uint_to_string).
(describe_change): Instead of an int flag, use a char *
auxiliary; this avoids the need for casts.
Assume free (NULL) works.
(change_file_owner): Return true/false, not 0/-1, since
we don't set errno.  All callers changed.
Use bool when appropriate.
(chown_files): Likewise.
2004-07-28 23:37:49 +00:00
Paul Eggert 65c2eab955 (main): int -> bool when appropriate. 2004-07-28 23:37:21 +00:00