Commit Graph
452 Commits
Author SHA1 Message Date
Jim Meyering 1490f2dbf3 od: fix a bug that arises when skipping exact length of file
* NEWS: Document the bug fix.
* src/od.c (skip): Call fseek even when n_skip is exactly the
same as the length of the current file.  Otherwise, the next
iteration would use unadjusted input stream pointer, thus ignoring
the desired "skip".  Report and patch by Paul GHALEB.
2007-08-14 09:47:05 +02:00
Jim Meyering 288524b39b Attempt to copy a regular file, even if stat says it is empty.
* NEWS: Document this bug fix.
* src/copy.c (copy_reg): Read from a regular file, even if it
appears (stat.st_size == 0) to be empty.  This reverts an
optimization introduced on 2005-11-23 for coreutils-6.0.
Otherwise, "cp /proc/cpuinfo /tmp" creates an empty file,
on e.g., linux-2.6.20.
* tests/cp/proc-zero-len: New file.  Test for the above.
* tests/cp/Makefile.am (TESTS): Add proc-zero-len.
Reported by Dan Berrangé.
2007-07-29 12:03:15 +02:00
Jim Meyering 0a744370bb ls --color: Don't stat symlinks when neither ORPHAN nor MISSING attribute has a color.
* src/ls.c (main): Don't set check_symlink_color when C_EXEC is
colored, unless ln=target (aka color_symlink_as_referent) is set.
(gobble_file): Set f->linkok = true also when !check_symlink_color.
http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/10608/focus=10927
Reported by Jeremy Maitin-Shepard.
* tests/strace: New file, contents extracted from...
* tests/mv/atomic: ...here.  Source strace.
* tests/ls/stat-free-symlinks: New file.  Test for the above.
Use strace to ensure that in this corner case, ls does not call stat.
* tests/ls/Makefile.am (TESTS): Add stat-free-symlinks.
* tests/Makefile.am (EXTRA_DIST): Add strace.
2007-07-15 22:13:44 +02:00
Jim Meyering 17cc46a11a THANKS: Add Pádraig Brady.
2007-07-08  Jim Meyering  <jim@meyering.net>
2007-07-08 16:42:50 +02:00
Jim Meyering c23c89db0f Make chgrp and chown diagnostics consistent.
* src/chown.c (main): Emit the diagnostic before the file name,
not after it, to be consistent with chgrp's diagnostic.
* src/chgrp.c (parse_group): Emit a ":" between the diagnostic
and the file name.
Reported by Egmont Koblinger.
* THANKS: Add Egmont Koblinger.
2007-06-16 12:53:40 +02:00
Jim Meyering 85c3924ce5 rmdir: give better diagnostics
* src/rmdir.c (remove_parents): Give a more descriptive/consistent
diagnostic upon failure.
(main): Likewise.
Suggestion from Joey Hess.
* THANKS: Add Joey Hess.
2007-06-13 15:53:12 +02:00
Jim Meyering e1afd98589 README: Also mention README-hacking,
for whose who start from
cloned/checked-out sources rather than from a distribution tarball.
Reported by Steve Ward.
* THANKS: Add Steve Ward.

Signed-off-by: Jim Meyering <jim@meyering.net>
2007-06-11 11:10:23 +02:00
Jim Meyering b1b0f5c556 bug-fix: cp would fail to write through a dangling symlink
* NEWS: Mention the bug fix.
* src/copy.c (copy_reg): When open fails with EEXIST, the destination
is lstat'able, and a symlink, call open again, but now without O_EXCL.
* tests/cp/thru-dangling: New file, to test for the above fix.
* tests/cp/Makefile.am (TESTS): Add thru-dangling.
* THANKS: Add Michael McLagan.
Bug report from Michael McLagan in <http://bugzilla.redhat.com/243588>.
2007-06-10 15:01:18 +02:00
Jim Meyering ab402c29f9 tr -c: don't abort when translating with S2 larger than complement of S1
* src/tr.c (main): Remove invalid assertion triggered by e.g.,
tr -c a '[b*256]'.  There's nothing wrong with having Set2 larger
than Set1.  Reported by Guntram Blohm.
* tests/tr/Test.pm (no-abort-1): Test for the above.
* NEWS: Mention this bug fix.
* THANKS: Add Guntram Blohm.
2007-05-04 10:03:01 +02:00
Jim Meyering aa3f52d17b Invoke rm via 'setuidgid ... env PATH="$PATH" ...', as in fail-eperm.
* tests/rm/fail-2eperm: Patch from AIDA Shinra.
Reported by Peter Dyballa.
* THANKS: Add AIDA Shinra and Peter Dyballa.
2007-05-02 23:34:33 +02:00
Jim Meyering 383713e030 * THANKS: Add Andreas Frische.
* NEWS: Mention today's ls --color fix.
* tests/ls-2/tests (sl-dangle): Add a test for today's fix.
2007-04-24 09:20:52 +02:00
Jim Meyering 25b8a7a987 cut synopsis: fix coreutils.texi, too.
* doc/coreutils.texi (cut invocation): Adjust synopsis to show that an
* THANKS: Add Rudolf Kastl.
OPTION is required.  Reported by Rudolf Kastl.
2007-04-16 22:01:46 +02:00
Jim Meyering 4d484fe09f Add a test for, and document, today's fix.
* NEWS: Mention today's ls --color fix.
* tests/ls-2/tests (sl-target): Add a test for today's fix.
* THANKS: Add Kirk Kelsey.
2007-04-07 20:51:13 +02:00
Jim Meyering 553d347d3e Fix a bug in how pr -m -s works.
* NEWS: Describe how the fix affects pr.
* src/pr.c (init_parameters): The --merge (-m) option does
not imply --expand-tabs (-e), so don't set "untabify_input".
Reported by Wis Macomson.
* tests/misc/pr: New file.  Test for the above fix.
* tests/misc/Makefile.am (TESTS): Add pr.
* THANKS: Update.
2007-03-18 16:21:26 +01:00
Jim Meyering d7226387a9 * src/env.c (main): When invoked with no arguments (i.e. when printing
the environment), use a local variable to iterate through the global
"environ" array, rather than "environ" itself.  This is solely to
avoid changing the environment for an LD_PRELOAD-substituted "puts"
or "exit" function.  Tiny patch by Harvey Eneman.  See
<http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/9735>.
* THANKS: Update.
2007-02-20 17:23:51 +01:00
Evan Hunt 482366105a Document what the ".0" in e.g., "-k 2,3.0" means, and...
* coreutils.texi (sort invocation): ... that it can be applied to the
field-end spec, but not the field-start one.  Patch from Evan Hunt.

Signed-off-by: Jim Meyering <jim@meyering.net>
2007-01-03 12:04:24 +01:00
Jim Meyering d69fc66d81 "cut -f 2- A B" no longer triggers a double-free bug
* src/cut.c (cut_fields): Set file-scoped global to NULL after
freeing it.  This avoids a double-free (and core dump on some systems)
for this usage: "echo 1>a; echo 2>b; cut -f2- a b".  Reported by
James Hunt in <http://bugzilla.redhat.com/220312>.
* NEWS: List this bug fix.
* THANKS: Mention him.
* tests/misc/cut: New file.
* tests/misc/Makefile.am (TESTS): Add cut.
2006-12-20 14:25:55 +01:00
Jim Meyering 4e48b4ce33 * tests/cp/open-perm-race: Correct the gdb-existence check.
Don't run either subsequent gdb command in a sub-shell.
Reported by Thomas Schwinge.
* THANKS: bring up to date.
2006-12-15 10:43:20 +01:00
Jim Meyering f594f1fb38 *** empty log message *** 2006-10-17 20:12:05 +00:00
Jim Meyering d1ea87316f *** empty log message *** 2006-10-17 13:48:27 +00:00
Jim Meyering 779168820b *** empty log message *** 2006-10-14 05:06:38 +00:00
Jim Meyering 509febe18b *** empty log message *** 2006-09-26 09:18:20 +00:00
Jim Meyering f951057414 *** empty log message *** 2006-09-25 06:22:35 +00:00
Jim Meyering 6e31234fbb *** empty log message *** 2006-07-20 08:33:19 +00:00
Jim Meyering 36a288e41a * src/copy.c (copy_internal): Don't work around old NFS clients like
SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
ENOTEMPTY upon failed rename.  Otherwise, we risk misinterpreting
a banal failure as a recursive move-into-self failure.
Reported by Florent Bayle in <http://bugs.debian.org/376749>.
2006-07-05 09:08:42 +00:00
Jim Meyering 593453d7bf *** empty log message *** 2006-06-03 08:29:28 +00:00
Jim Meyering fe7323d6cf *** empty log message *** 2006-05-28 09:02:42 +00:00
Jim Meyering 58f42eb607 *** empty log message *** 2006-05-15 20:18:49 +00:00
Jim Meyering 6dd69d3281 *** empty log message *** 2006-05-10 13:39:30 +00:00
Jim Meyering c139c9a58b . 2006-05-03 10:11:25 +00:00
Jim Meyering 568eec4a9d *** empty log message *** 2006-03-30 13:26:59 +00:00
Jim Meyering 1c952c4d7d *** empty log message *** 2006-03-27 07:32:44 +00:00
Jim Meyering bf46e04149 *** empty log message *** 2006-03-10 21:24:38 +00:00
Jim Meyering 64e8ade1fa *** empty log message *** 2006-03-05 17:29:13 +00:00
Jim Meyering c501fbc346 *** empty log message *** 2006-02-06 09:06:50 +00:00
Jim Meyering 6e7b489f51 *** empty log message *** 2006-02-04 10:45:44 +00:00
Jim Meyering 529ecbddcc *** empty log message *** 2006-01-23 20:13:44 +00:00
Jim Meyering 6757e33c92 *** empty log message *** 2006-01-10 09:16:10 +00:00
Jim Meyering b6541058ce *** empty log message *** 2006-01-10 07:31:49 +00:00
Jim Meyering 55897502a6 *** empty log message *** 2005-12-09 16:27:26 +00:00
Jim Meyering db604d8e8a *** empty log message *** 2005-11-16 09:30:25 +00:00
Jim Meyering fdbc317e46 *** empty log message *** 2005-11-13 18:57:03 +00:00
Jim Meyering 2b46dc5403 *** empty log message *** 2005-11-11 17:16:30 +00:00
Jim Meyering 4c60a9a964 s/expensive/very expensive/ in a comment. 2005-11-08 08:19:57 +00:00
Jim Meyering 59eb233924 *** empty log message *** 2005-11-07 21:39:40 +00:00
Jim Meyering c30dcb08eb . 2005-10-25 13:47:38 +00:00
Jim Meyering 55b84cf932 *** empty log message *** 2005-10-25 12:03:56 +00:00
Jim Meyering d294610a58 *** empty log message *** 2005-10-23 15:47:07 +00:00
Jim Meyering 314397e7c5 *** empty log message *** 2005-10-03 12:11:49 +00:00
Jim Meyering 8890d86818 *** empty log message *** 2005-09-11 07:41:56 +00:00