Commit Graph
5676 Commits
Author SHA1 Message Date
Jim Meyering 256d18e81b * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
Correctly access SRC_SB's element ST_AUTHOR.
2006-07-26 14:43:00 +00:00
Jim Meyering d2c6ae7fbc * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
than having the code test for all of the other types first.
Hoist the set-uid/gid-testing code "up" into this new block.
Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
C_ORPHAN, not as C_FILE.

* doc/coreutils.texi (What information is listed): Mention that missing
pieces of information are marked with "?".  From Paul Eggert.
2006-07-26 14:06:57 +00:00
Jim Meyering 2465b478fd Checking in a change from Paul.
2006-07-25  Paul Eggert  <eggert@cs.ucla.edu>

* src/ls.c (DT_INIT): Remove.  All uses removed.
(enum filetype): Use an ordinary enum rather than trying to keep
the values in sync with DT_FIFO etc.  That way, we don't have
to make special assumptions about them.  All uses changed.
(whiteout): New constant member of enum filetype.
(filetype_letter): New constant, for use with enum filetype.
(FILETYPE_INDICATORS): New initializer list.
(print_dir): Add case for DT_WHT.
(gobble_file): If stat fails, don't discard information from
readdir; instead, preserve it so it can be printed.
(print_long_format): Fall back on readdir result if stat info
is not available.  Use "?" to denote each unknown mode char,
instead of an overall "?", since we now know some of the mode
typically.
(print_type_indicator): Now that MODE isn't necessarily
useful, guard all uses.
Now that two blocks in the type-checking tree can set "type = C_FILE",
move the suffix-handling code out and down.
2006-07-26 13:47:41 +00:00
Jim Meyering efb40f6b0f Prepare for the above change.
* src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
and adjust uses.  From a patch by Paul Eggert.
2006-07-26 13:33:07 +00:00
Jim Meyering 03d872537a * src/ls.c: Correct indentation/formatting in a few places. 2006-07-26 09:52:43 +00:00
Jim Meyering 0b34021d6d * src/ls.c (gobble_file): When handling a stat-failed entry,
print the entry name not the absolute_name -- to be consistent
with the usual case.
* tests/ls/stat-failed: Update accordingly.
2006-07-25 16:35:59 +00:00
Jim Meyering fd991bcc57 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling symlinks. 2006-07-25 15:34:58 +00:00
Jim Meyering ef79e4ea3b * src/dircolors.hin: Mention that ORPHAN refers not just to dangling symlinks. 2006-07-25 15:33:57 +00:00
Jim Meyering c04a374bb0 Get --dired offsets right when handling stat-failed entries.
* src/ls.c (print_long_format): Be careful to increment P by the
appropriate amount, even when inode_number_width and nlink_width
are zero.
* tests/ls/stat-failed: Test for the above.
2006-07-25 15:30:27 +00:00
Jim Meyering 5a06d062c7 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
have_acl member.  That would happen for a directory with both a
non-stat'able entry and one with an ACL.
2006-07-25 15:25:37 +00:00
Jim Meyering 3a208b1404 * src/ls.c (gobble_file): Make it so failure to stat a
non-command-line file provokes an exit status of 1, not 0.
Say "cannot access" rather than "cannot stat".
* tests/ls/stat-failed: New file/test, for the above.
* tests/ls/Makefile.am (TESTS): Add stat-failed.
2006-07-25 15:23:59 +00:00
Jim Meyering a321dfb09d * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere. 2006-07-25 15:13:56 +00:00
Jim Meyering 1827b515aa * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
Replace all occurrences of "type == command_line" with the
equivalent, "command_line_arg".
2006-07-25 15:12:26 +00:00
Jim Meyering ccb1883fcd * src/ls.c: Apply the stat-failed parts of Red Hat's
coreutils-selinux.patch.  From Ulrich Drepper.
This makes it so files not mentioned on the command line (e.g.,
names read from a directory that *is* mentioned on the command
line) for which stat fails are still listed.  With --color,
such files are colored just like ORPHANs (aka dangling symlinks).
2006-07-25 15:09:56 +00:00
Jim Meyering 627f9b7fb1 * src/df.c (n_valid_args): Declare global to be static. 2006-07-25 14:06:21 +00:00
Jim Meyering c6a13a3354 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
Reported by Tim Waugh.
Also remove the comment duplicating much of --help output.
2006-07-21 13:32:40 +00:00
Jim Meyering a1eae84aed (FILE_TYPE_INDICATOR_OPTION): Reposition this new name so the list remains alphabetized. 2006-07-21 09:14:39 +00:00
Jim Meyering 9e0a095be6 Fix another bug: ls --indicator-style=file-type would call
stat for a symlink, even though it wasn't always needed.
In some cases, that unnecessary stat would cause ls to fail.
* src/ls.c (gobble_file): Don't treat symlinks specially (in
requiring a stat syscall).  Remove the offending exclusion.
* NEWS: Mention the fix.
* tests/ls/stat-dtype: New file/test, for the above fix.
Also exercises the new df feature, below.
2006-07-21 08:49:24 +00:00
Jim Meyering 2060c55141 * src/df.c (main): Fail and don't print the headers if no
file system is processed.  This makes it easy to test whether
a specified directory is on a file system of a given type or types.
Otherwise, applications would have had to parse df's output.
E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
2006-07-20 15:42:26 +00:00
Jim Meyering 3ddfde6897 Fix a bug: ls --file-type worked like --indicator-style=slash,
rather than like --indicator-style=file-type.

(FILE_TYPE_INDICATOR_OPTION): New enum member.
(long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
not to 'p'.
(decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
2006-07-20 10:20:23 +00:00
Jim Meyering 7d97c337a7 * src/ls.c (print_dir): Give a better diagnostic for failed opendir. 2006-07-19 10:36:02 +00:00
Paul Eggert a58ac00556 Regenerate. 2006-07-17 03:52:18 +00:00
Paul Eggert 577faf65e3 (main): Adjust to new mode_adjust API. 2006-07-17 03:11:01 +00:00
Paul Eggert 1d396d7008 (main): Adjust to new mode_adjust API. 2006-07-17 03:10:29 +00:00
Paul Eggert 76b12f0005 (struct mkdir_options): New struct.
(announce_mkdir, make_ancestor): New functions.
(main): Use them.  Adjust to mode_adjust API change.  Stick with
umask 0.  Use make_dir_parents for all the work.
2006-07-17 03:10:10 +00:00
Paul Eggert 83978a5654 Include mkancesdirs.h.
(announce_mkdir, make_ancestor): New functions.
(DEFAULT_MODE): New macro, specifying initial value of 'mode'.
(mode): Use it.
(dir_mode, dir_mode_bits): New vars.
(main): Set dir modes separately from nondir, so that the X
op of -m works correctly.
(main): Remove cwd_errno cruft, since make_dir_parents no longer
affects cwd.  Adjust to new make_dir_parents API.
(install_file_in_file_parents): 2nd arg is now char *, not char
const *.  Use mkancesdirs instead of rolling our own code.
(change_attributes): Don't worry about AFS, since that kludge
should not be needed any more.
2006-07-17 03:09:49 +00:00
Paul Eggert 8401b6ae54 (process_file): Adjust to mode_adjust API change. 2006-07-17 03:09:26 +00:00
Paul Eggert 77c9d9a009 (do_decode): Output to parameter OUT, not to stdout. 2006-07-14 17:54:54 +00:00
Paul Eggert d6697c60c3 Assume <dirent.h> exists, since gnulib assumes this now as well. 2006-07-11 17:22:15 +00:00
Paul Eggert 914c8674a5 Regenerate. 2006-07-09 17:20:26 +00:00
Paul Eggert 197b96d069 Adjust to today's renaming changes in system.h. 2006-07-09 17:08:55 +00:00
Paul Eggert b3e1ad7a5d (print_it): Don't assume char is unsigned. 2006-07-09 17:07:12 +00:00
Paul Eggert b35b31b0f8 (print_esc): Don't assume char is unsigned. 2006-07-09 17:06:35 +00:00
Paul Eggert 20c336e6d2 (create_fullname): Don't assume char is unsigned. 2006-07-09 17:06:06 +00:00
Paul Eggert 2b001e3490 (is_blank): Remove; no longer needed. All uses
replaced by isblank (to_uchar (...)).
2006-07-09 17:05:33 +00:00
Paul Eggert c7a6c4014f (unexpand): Don't assume that isprint etc. return
booleans (needed for pre-C99 hosts).
2006-07-09 17:05:13 +00:00
Paul Eggert 8c572b86f6 (is_char_class_member): Don't assume that isprint etc. return
booleans (needed for pre-C99 hosts).
2006-07-09 17:04:48 +00:00
Paul Eggert 613b3f819c (initialize_regex, fix_output_parameters): Don't assume that isprint
etc. return booleans (needed for pre-C99 hosts).
(SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
(copy_unescaped_string): Don't assume char is unsigned.
2006-07-09 17:04:06 +00:00
Paul Eggert 925076c5d6 (check_punctuation): Don't assume that isprint etc. return
booleans (needed for pre-C99 hosts).
2006-07-09 17:03:20 +00:00
Paul Eggert 55755b03cd (expand): Don't assume that isprint etc. return
booleans (needed for pre-C99 hosts).
2006-07-09 17:02:53 +00:00
Paul Eggert 1ee1c4d4a3 (inittables): Use toupper rather than
islower followed by toupper; it's simpler and typically
faster now that we assume at least C89 semantics.  Similarly
for tolower.
2006-07-09 17:02:17 +00:00
Paul Eggert 7c3fd7cbec (apply_translations): Use toupper rather than
islower followed by toupper; it's simpler and typically
faster now that we assume at least C89 semantics.  Similarly
for tolower.
2006-07-09 17:01:38 +00:00
Paul Eggert d740f05066 (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
convenience on GNU systems.  All uses changed.  Don't bother
looking for any dirent.h substitute other than ndir.h.
(D_INO): Remove unnecessary parentheses.
(IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
(ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
(ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove.  All uses changed
to ctype.h equivalents.
(isblank): Renamed from ISBLANK.  Check for HAVE_DECL_ISBLANK too.
All uses changed.
2006-07-09 17:01:13 +00:00
Jim Meyering 6b535b03bb * src/dd.c (skip): Remove one of two adjacent "the"s in a comment. 2006-07-08 06:04:18 +00:00
Jim Meyering b544360dab * src/ls.c (usage): Correct the description of -G: it is useful
only in a long listing.  Reported by Martin Pool in
<https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
2006-07-05 10:17:24 +00:00
Jim Meyering 36a288e41a * src/copy.c (copy_internal): Don't work around old NFS clients like
SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
ENOTEMPTY upon failed rename.  Otherwise, we risk misinterpreting
a banal failure as a recursive move-into-self failure.
Reported by Florent Bayle in <http://bugs.debian.org/376749>.
2006-07-05 09:08:42 +00:00
Jim Meyering 21f0c888a2 Regenerate, to remove fuzz. 2006-07-05 06:57:00 +00:00
Jim Meyering a9cf203e2d Plug another unusual leak.
(AD_mark_helper): Free malloc'd filename if hash_insert says
that string is already in the hash table.
2006-07-03 17:38:20 +00:00
Jim Meyering a47c5ca291 The dev/inode of the topmost directory in each hierarchy were not
being recorded.
* src/remove.c (remove_cwd_entries): Don't call cycle_check here.
(AD_push): Call it from here instead.
2006-07-03 15:10:35 +00:00
Jim Meyering 2741ffb8b4 Fix two small leaks.
* src/remove.c (AD_stack_clear): New function.
(rm_1): Use it.
(AD_pop_and_chdir): Free *prev_dir just before longjmp.
2006-07-03 13:14:01 +00:00