Commit Graph
3872 Commits
Author SHA1 Message Date
Jim Meyering 873a22151f . 2003-07-23 06:59:26 +00:00
Jim Meyering 6315f15a23 (parse_tabstops): Detect overflow in tabstop sizes. 2003-07-23 06:57:57 +00:00
Jim Meyering 8d69e13ee5 Include xstrndup.h.
(xstrndup): Remove function, now that it's been factored out into
it's own file.
2003-07-23 06:39:44 +00:00
Jim Meyering b220480e9d Tweak comment: Solaris2.5.1 -> Solaris 2.5.1 2003-07-23 06:38:18 +00:00
Jim Meyering 1818879388 Tweak comment: Solaris2.7 -> Solaris 2.7 2003-07-23 06:37:45 +00:00
Jim Meyering 3d0b2cc66a (wc): Fix typo in computation of file from file_x,
which caused the former to be used uninitialized if file_x was
nonzero.
2003-07-23 05:47:57 +00:00
Jim Meyering a19486436f tweak comment 2003-07-22 21:56:23 +00:00
Jim Meyering 9239223865 (set_fields): Use xcalloc in place of xmalloc+memset. 2003-07-22 21:53:39 +00:00
Jim Meyering 4457508c7a don't include stdboo.h. it's already included via system.h 2003-07-22 14:18:58 +00:00
Jim Meyering 0bdc16c6f5 . 2003-07-22 14:16:50 +00:00
Jim Meyering 6dc75c643b (main) [lint]: Initialize spec_list_string to avoid warning. 2003-07-22 14:15:31 +00:00
Jim Meyering e21334b795 Don't include <unistd.h>. system.h already does that. 2003-07-22 14:13:37 +00:00
Jim Meyering 3fe298f13f (set_fields): Mark all selected indices before trying to
determine range endpoints.
2003-07-22 13:00:45 +00:00
Jim Meyering bf2cf0b7ba Begin to address this comment: What if someone wants to
extract the 1,000,000-th field of some huge input file?
The first step is to rearrange things so that the values
in the printable_field array are all 0/1 rather than 0/1/2.

(RANGE_START_SENTINEL): Remove.
Store range-start indices in a hash table, rather than
overloading the `printable_field' array.
(range_start_ht): New global.
(hash_int, hash_compare_ints, is_range_start_index): New functions.
(print_kth): Use is_range_start_index; don't test printable_field.
(set_fields): Detect overflow.
(set_fields): Insert each range-start index into range_start_ht.
(main): Call set_fields only once, and only after
output_delimiter_specified and (if required) range_start_ht have
been defined.
2003-07-22 11:56:24 +00:00
Jim Meyering 1eb0fd1dd1 (get_input_fstatus): Fix typo: `stat' was being
invoked with a null pointer when there were no file arguments.
2003-07-20 21:13:04 +00:00
Jim Meyering 72214f2990 . 2003-07-20 16:02:28 +00:00
Jim Meyering 224d5c8170 (write_counts): Add a comment.
(wc): Rename `file' parameter.
Set new local, `file', to be the file name, or (when it's NULL)
_("standard output") so that all uses of `file' use the proper value.
Use STREQ, not strcmp.
2003-07-20 15:45:29 +00:00
Jim Meyering 6e1923f4c1 (number_width): New var.
(posixly_correct): Remove.
(struct fstatus): New struct.
(write_counts): Output fields of width number_width.
Do not worry about POSIXLY_CORRECT.
Use null file, not empty-string file, to denote stdin,
since "" is a valid file name on some hosts.
(wc, wc_file): New arg fstatus.  Use it to avoid invoking fstat
if possible.
(wc):  Avoid problems if end_pos - current_pos overflows.
Do not print odd message if stdin has a read error.
(get_input_fstatus, compute_number_width): New functions.
(main): Use them to implement the new behavior.
Ignore POSIXLY_CORRECT.
2003-07-20 15:22:25 +00:00
Jim Meyering db34cf4ee6 Include "exitfail.h".
(main): Set exit_failure rather than calling close_stdout_set_status.
2003-07-19 08:17:06 +00:00
Jim Meyering fe52d65af0 Include "exitfail.h".
(main): Set exit_failure rather than calling close_stdout_set_status.
2003-07-19 08:16:38 +00:00
Jim Meyering 1d7432c0ef (main): Use close_stdout via atexit.
Now `sort --version' and `sort --help' fail, as they should
when their output is redirected to /dev/full.
2003-07-18 08:53:05 +00:00
Jim Meyering ec5c04d7d8 (usage): Don't call close_stdout here.
(main): Use close_stdout via atexit.
Now `su --version > /dev/full' fails, as it should.
Somehow, the change of 2000-05-07 that purports to fix this
was not checked in.
2003-07-18 08:38:43 +00:00
Jim Meyering 7f1636878f (writeline): Use a SPACE, not a TAB between the
count and the corresponding line, as required by POSIX.
2003-07-18 07:47:05 +00:00
Jim Meyering 30d8071d60 Include "exitfail.h".
(main): Set exit_failure, not xalloc_exit_failure and xmemcoll_exit_failure.
2003-07-18 07:23:38 +00:00
Jim Meyering 1eaf0e9870 Include "exitfail.h", "quotearg.h".
(EXPR_INVALID, EXPR_ERROR): New constants.
(nomoreargs, null, toarith, nextarg): Return bool, not int.
(syntax_error): New function, exiting with status 2.  Use it
insteading of printing "syntax error" ourselves.
(main): Initialize exit_failure to EXPR_ERROR.
Exit with EXPR_INVALID on syntax error (too few arguments).
(nextarg): Use strcmp, not strcoll; strcoll might return
an undesirable 0, or might fail.
(docolon, eval4, eval3): Exit with status 3 on invalid argument type
or other such error.
(eval2): Report an error if strcoll fails in a string comparison.
2003-07-18 07:22:38 +00:00
Jim Meyering e992d666e1 (NOHUP_FOUND_BUT_CANNOT_INVOKE, NOHUP_FAILURE):
Use an anonymous `enum', rather than #define.
2003-07-18 07:18:54 +00:00
Jim Meyering 3497dfc9c1 . 2003-07-17 22:27:44 +00:00
Jim Meyering 17d2d3a72f (main): Fix bug introduced on 2003-05-10 (for 5.0.1)
whereby kill would always attempt to operate on argv[0] and fail.
2003-07-16 19:42:34 +00:00
Jim Meyering b1fd798094 (integer_expected_error): Improve diagnostic -- now,
it also matches the one from bash's builtin test.
(binary_operator): Add \n at end of diagnostic.
2003-07-16 10:28:52 +00:00
Jim Meyering aad28eb267 (AUTHORS): Replace 3-letter usernames with the actual
names of authors that I just found in bash's builtins/test.def.
2003-07-16 06:54:33 +00:00
Jim Meyering 0049fa1eda Running `[' with no arguments would evoke a segfault.
(main) [LBRACKET]: Move initialization of argv to
precede potential use via test_syntax_error.
2003-07-16 06:43:02 +00:00
Jim Meyering 35f71d4a00 (AM_CPPFLAGS): Rename from `INCLUDES', to avoid warning from automake -Wall. 2003-07-16 06:33:09 +00:00
Jim Meyering 48606016b8 (NOHUP_FAILURE, NOHUP_FOUND_BUT_CANNOT_INVOKE): Define.
(main): Use them.
2003-07-13 09:25:21 +00:00
Jim Meyering 8329b522c0 *** empty log message *** 2003-07-13 08:46:53 +00:00
Jim Meyering 15c5a31fb5 *** empty log message *** 2003-07-13 08:46:21 +00:00
Jim Meyering 32a2c6f6d9 . 2003-07-12 20:47:23 +00:00
Jim Meyering a3c0bb50f3 (bin_SCRIPTS): Remove use of just-removed $(OPTIONAL_BIN_ZCRIPTS). 2003-07-12 18:43:36 +00:00
Jim Meyering 12237951e6 (localedir.h): Put the 2>&1' after the redirect target, not before the >'. 2003-07-12 18:25:51 +00:00
Jim Meyering 4f78b3f40f (remove_dir): Give a diagnostic upon failed save_cwd,
now that that function no longer calls `error'.
2003-07-12 16:22:39 +00:00
Jim Meyering c8f1cbc602 (find_mount_point): Emit a diagnostic for each
failed syscall, rather than relying on caller to do that.
The caller couldn't do a good job, anyhow -- too many different
ways to fail (each with a different referent).
Give a diagnostic upon failed save_cwd, now that that function
no longer calls `error'.
(show_point): Don't diagnose find_mount_point's errors, now that
it handles them itself.
2003-07-12 16:21:45 +00:00
Jim Meyering 7e815d32f3 tweak spacing 2003-07-12 16:17:14 +00:00
Jim Meyering 21f65c951c (find_mount_point): Don't let free clobber errno upon failed chdir 2003-07-12 15:44:14 +00:00
Jim Meyering a29f991b84 * src/sys2.h: Remove alloca-related block.
* src/system.h: Include <alloca.h> here, instead.
2003-07-12 11:40:03 +00:00
Jim Meyering 64521cfa9a It appears that the `#pragma alloca' included via "system.h" is
adequate, since join.c uses alloca, yet lacked an in-file #pragma.

Remove `#pragma alloca'.
2003-07-12 11:38:43 +00:00
Jim Meyering 8e34468f61 (change_file_owner): Do not restore any special
permission bits (e.g., set-user-ID, set-group-ID) that are reset
by chown(2) on some systems.  Suggestion and insistence :-) from
Michael Stone.
2003-07-12 08:37:36 +00:00
Jim Meyering 4e85b8c0c8 . 2003-07-11 22:26:40 +00:00
Jim Meyering 96f7791a8b . 2003-07-11 20:38:23 +00:00
Jim Meyering 0f46c3a0aa (EXTRA_SCRIPTS): Remove definition.
(bin_PROGRAMS): Add nohup.
(EXTRA_DIST): Remove nohup.sh.
(all_programs): Remove use of $(EXTRA_SCRIPTS).
2003-07-11 20:37:15 +00:00
Jim Meyering 8db77b8978 New file. Rewrite of nohup.sh in C.
This solves a portability problem: on at least Solaris systems,
when nohup.sh used the vendor /bin/sh, it would exit with status
of `1' rather than the required 126 or 127 upon failure to exec
the specified program.
2003-07-11 20:34:29 +00:00
Jim Meyering e1584f504f (diagnose_copy_fd_failure): New function, renamed from
the macro, COPY_FD_DIAGNOSE.
(diagnose_copy_fd_failure): Enclose diagnostic in _(...).
(head_file): Likewise.
2003-07-11 11:12:44 +00:00