From e85bf8468fd63051e762e27da4e35215abaf07f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?=
Date: Mon, 2 Nov 2026 17:28:37 +0000
Subject: [PATCH] seq: ensure termination at floating point limits
* src/seq.c (dump_strings): Rearrange limit checks to
reduce rounding affects. Also add sanity check on
on the iteration number limit.
* tests/seq/seq-no-progress.sh: Add a new test.
* tests/local.mk: Reference the new test.
* NEWS: Mention the fix.
Discovered by Anthropic's OSS Scanner, as bug ANT-2026-RI0OLUBX.
---
NEWS | 5 ++++
src/seq.c | 12 ++++++++-
tests/local.mk | 1 +
tests/seq/seq-no-progress.sh | 49 ++++++++++++++++++++++++++++++++++++
4 files changed, 66 insertions(+), 1 deletion(-)
create mode 100755 tests/seq/seq-no-progress.sh
diff --git a/NEWS b/NEWS
index 45abd0077..22df2eb9d 100644
--- a/NEWS
+++ b/NEWS
@@ -129,6 +129,11 @@ GNU coreutils NEWS -*- outline -*-
resolves to a path beginning with the symbolic link itself.
[bug introduced in coreutils-9.0]
+ 'seq' no longer outputs the same number indefinitely when the increment
+ is too small to change the floating point value of FIRST.
+ For example with 'seq -w 1e40 1e40' or 'seq 1 1e-40 1'.
+ [This bug was present in "the beginning".]
+
'sort --compress-program=PROG' no longer treats an unset PATH environment
variable as equivalent to a PATH environment variable defined to an empty
string. On typical platforms, that would result in PROG being executed from
diff --git a/src/seq.c b/src/seq.c
index a49a18988..acae21fd0 100644
--- a/src/seq.c
+++ b/src/seq.c
@@ -313,12 +313,22 @@ print_numbers (char const *fmt, struct layout layout,
write_error ();
if (out_of_range)
break;
+ if (i + 1 == i)
+ error (EXIT_FAILURE, EOVERFLOW, _("sequence counter exhausted"));
/* Mathematically equivalent to 'x += step;', and typically
less subject to rounding error. */
x = first + i * step;
- out_of_range = (step < 0 ? x < last : last < x);
+ /* If STEP is too small to change X, then X might never pass LAST,
+ so compare the offsets from FIRST, which are not so rounded. */
+ if (x == x0
+ && ! (step < 0
+ ? last - first <= i * step : i * step <= last - first))
+ break;
+
+ /* Also treat NaN, from "seq -- -inf inf 0", as out of range. */
+ out_of_range = ! (step < 0 ? last <= x : x <= last);
if (out_of_range)
{
diff --git a/tests/local.mk b/tests/local.mk
index fbaaa653f..77cb83439 100644
--- a/tests/local.mk
+++ b/tests/local.mk
@@ -282,6 +282,7 @@ all_tests = \
tests/seq/seq-io-errors.sh \
tests/seq/seq-locale.sh \
tests/seq/seq-long-double.sh \
+ tests/seq/seq-no-progress.sh \
tests/seq/seq-precision.sh \
tests/head/head.pl \
tests/head/head-elide-tail.pl \
diff --git a/tests/seq/seq-no-progress.sh b/tests/seq/seq-no-progress.sh
new file mode 100755
index 000000000..da48dbb85
--- /dev/null
+++ b/tests/seq/seq-no-progress.sh
@@ -0,0 +1,49 @@
+#!/bin/sh
+# Ensure seq terminates when floating point arithmetic stops progressing.
+
+# Copyright (C) 2026 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see