From 3db7c2c03c4c6daf358925d1c585fcbb478fa25a Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 20 Aug 2009 10:36:30 +0200 Subject: [PATCH] install: avoid a portability bug when compiling with non-gcc * src/install.c (extra_mode): Be careful to return only a 0 or 1 value, since this is a "bool" function, and there are still some compilers for which this is necessary. Without this change, Bernhard Voelker reported that the Forte Developer 7 C 5.4 2002/03/09 compiler would produce a malfunctioning "install" binary. Details in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/17710/focus=17760 --- src/install.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/install.c b/src/install.c index 73b3981ef..19efb1d1b 100644 --- a/src/install.c +++ b/src/install.c @@ -189,7 +189,7 @@ static bool extra_mode (mode_t input) { const mode_t mask = ~S_IRWXUGO & ~S_IFMT; - return input & mask; + return !! (input & mask); } /* Return true if copy of file SRC_NAME to file DEST_NAME is necessary. */