From 110efa89e0fa60ef2fe0425bb86fd234d4c72a20 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Tue, 10 Nov 2026 20:30:37 +0000 Subject: [PATCH] tests: od: fix false failure on macOS * tests/od/od-j.sh: Read from /dev/zero again, as macOS stops reading at OFF_T_MAX. --- tests/od/od-j.sh | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/od/od-j.sh b/tests/od/od-j.sh index 082d23f53..7cf1c5ac3 100755 --- a/tests/od/od-j.sh +++ b/tests/od/od-j.sh @@ -40,18 +40,21 @@ for file in ${srcdir=.}/tests/init.sh /proc/version /sys/kernel/profiling; do done # Test that offset overflows are properly diagnosed. +# Use two inputs since macOS stops reading /dev/zero at OFF_T_MAX. OFFSET=$(expr $INTMAX_MAX - 1) || framework_failure_ printf '%o 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\n' $OFFSET \ >exp-out || framework_failure_ echo 'od: offset overflow' >exp-err || framework_failure_ for opt in '' -v; do - returns_ 1 timeout 10 od $opt -t x1 -j $OFFSET /dev/zero >out 2>err || fail=1 + returns_ 1 timeout 10 od $opt -t x1 -j $OFFSET /dev/zero /dev/zero \ + >out 2>err || fail=1 compare exp-out out || fail=1 compare exp-err err || fail=1 done -returns_ 1 timeout 10 od -S 1 -j $OFFSET /dev/zero >out 2>err || fail=1 +returns_ 1 timeout 10 od -S 1 -j $OFFSET /dev/zero /dev/zero \ + >out 2>err || fail=1 compare /dev/null out || fail=1 compare exp-err err || fail=1