From 89abf2a67a9ab2a2e80adcac3d59e2ac4cf7b2ac Mon Sep 17 00:00:00 2001 From: Ricardo Garcia Date: Mon, 20 Jun 2011 21:25:04 +0200 Subject: [PATCH] Fix crypt_blowfish 8-bit character mishandling Bug reported in the crypt_blowfish implementation from Solar Designer. For more information, see: http://www.openwall.com/lists/oss-security/2011/06/20/2 --- crypt_blowfish/crypt_blowfish.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypt_blowfish/crypt_blowfish.c b/crypt_blowfish/crypt_blowfish.c index 1939027..6976f7c 100644 --- a/crypt_blowfish/crypt_blowfish.c +++ b/crypt_blowfish/crypt_blowfish.c @@ -554,7 +554,7 @@ static void BF_set_key(__CONST char *key, BF_key expanded, BF_key initial) tmp = 0; for (j = 0; j < 4; j++) { tmp <<= 8; - tmp |= *ptr; + tmp |= (unsigned char)*ptr; if (!*ptr) ptr = key; else ptr++; }