mirror of
https://github.com/regclient/regclient.git
synced 2025-04-18 22:44:00 +03:00
I feel like I need to explain, this is all to move the descriptor package. The platform package could not use the predefined errors in types because of a circular dependency from descriptor. The most appropriate way to reorg this is to move descriptor out of the type package since it was more complex than a self contained type. When doing that, type aliases were needed to avoid breaking changes to existing users. Those aliases themselves caused circular dependency loops because of the media types and errors, so those were also pulled out to separate packages. All of the old values were aliased and deprecated, and to fix the linter, those deprecations were fixed by updating the imports... everywhere. Signed-off-by: Brandon Mitchell <git@bmitch.net>
104 lines
2.2 KiB
Go
104 lines
2.2 KiB
Go
package limitread
|
|
|
|
import (
|
|
"bytes"
|
|
"errors"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/regclient/regclient/types/errs"
|
|
)
|
|
|
|
func TestLimitRead(t *testing.T) {
|
|
t.Parallel()
|
|
byte0 := []byte("")
|
|
byte5 := []byte("12345")
|
|
byte10 := []byte("1234567890")
|
|
tt := []struct {
|
|
name string
|
|
limit int64
|
|
src []byte
|
|
try int64
|
|
expectBytes []byte
|
|
expectLen int
|
|
expectErr error
|
|
}{
|
|
{
|
|
name: "empty",
|
|
limit: 0,
|
|
src: byte0,
|
|
try: 0,
|
|
expectBytes: byte0,
|
|
expectLen: 0,
|
|
expectErr: io.EOF,
|
|
},
|
|
{
|
|
name: "exact length",
|
|
limit: 5,
|
|
src: byte5,
|
|
try: 5,
|
|
expectBytes: byte5,
|
|
expectLen: 5,
|
|
expectErr: nil,
|
|
},
|
|
{
|
|
name: "read less",
|
|
limit: 5,
|
|
src: byte10,
|
|
try: 5,
|
|
expectBytes: byte5,
|
|
expectLen: 5,
|
|
expectErr: nil,
|
|
},
|
|
{
|
|
name: "try more",
|
|
limit: 5,
|
|
src: byte5,
|
|
try: 10,
|
|
expectBytes: byte5,
|
|
expectLen: 5,
|
|
expectErr: io.EOF,
|
|
},
|
|
{
|
|
name: "read more",
|
|
limit: 9,
|
|
src: byte10,
|
|
try: 10,
|
|
expectErr: errs.ErrSizeLimitExceeded,
|
|
},
|
|
}
|
|
for _, tc := range tt {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
lr := LimitRead{
|
|
Reader: bytes.NewReader(tc.src),
|
|
Limit: tc.limit,
|
|
}
|
|
tgt := make([]byte, tc.try)
|
|
result, err := lr.Read(tgt)
|
|
// on a short read, try again for the EOF
|
|
if err == nil && result < int(tc.try) {
|
|
result2, err2 := lr.Read(tgt[result:])
|
|
result += result2
|
|
err = err2
|
|
}
|
|
if tc.expectErr != nil {
|
|
if err == nil {
|
|
t.Errorf("read did not fail")
|
|
} else if tc.expectErr.Error() != err.Error() && !errors.Is(err, tc.expectErr) {
|
|
t.Errorf("unexpected error, expected %v, received %v", tc.expectErr, err)
|
|
}
|
|
return
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("read failed: %v", err)
|
|
}
|
|
if result != tc.expectLen {
|
|
t.Errorf("read length mismatch, expected %d, received %d", tc.expectLen, result)
|
|
}
|
|
if !bytes.Equal(tgt[:result], tc.expectBytes) {
|
|
t.Errorf("read bytes mismatch, expected %s, received %s", string(tc.expectBytes), string(tgt[:result]))
|
|
}
|
|
})
|
|
}
|
|
}
|