Breaking: Disable legacy packages by default.

Legacy packages may still be used with "-tags legacy" added to the build.
They may be permanently removed in a future release.

Signed-off-by: Brandon Mitchell <git@bmitch.net>

Makefile

@@ -20,7 +20,7 @@ VCS_VERSION?=$(shell vcs_describe="$$(git describe --all)"; \
   echo "$${vcs_version}" | sed -r 's#/+#-#g')
 VCS_TAG?=$(shell git describe --tags --abbrev=0 2>/dev/null || true)
 LD_FLAGS?=-s -w -extldflags -static -buildid= -X \"github.com/regclient/regclient/internal/version.vcsTag=$(VCS_TAG)\"
-GO_BUILD_FLAGS?=-trimpath -ldflags "$(LD_FLAGS)" -tags nolegacy
+GO_BUILD_FLAGS?=-trimpath -ldflags "$(LD_FLAGS)"
 DOCKERFILE_EXT?=$(shell if docker build --help 2>/dev/null | grep -q -- '--progress'; then echo ".buildkit"; fi)
 DOCKER_ARGS?=--build-arg "VCS_REF=$(VCS_REF)" --build-arg "VCS_VERSION=$(VCS_VERSION)"
 GOPATH?=$(shell go env GOPATH)

internal/retryable/error.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 package retryable
 

internal/retryable/retryable.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Package retryable is a legacy package, functionality has been moved to reghttp
 package retryable

regclient/blob/blob.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Package blob is a legacy package, this has been moved to the types/blob package
 package blob

regclient/config.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Legacy package, this has been moved to the config package
 

regclient/config/host.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Package config is a legacy package, this has been moved to the config package
 package config

regclient/error.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Legacy package, this has been moved to the types/error.go package
 

regclient/manifest/manifest.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Package manifest is a legacy package, this has been moved to the types/manifest package
 package manifest

regclient/mediatype.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Legacy package, this has been moved to the top level types/mediatype.go package
 

regclient/regclient.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 //lint:file-ignore SA1019 Ignore deprecations since this entire package is deprecated
 

regclient/template.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Legacy package, this has been moved to the pkg/template package
 

regclient/types/error.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Legacy package, this has been moved to top level types package
 

regclient/types/mediatype.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Legacy package, this has been moved to top level types package
 

regclient/types/ratelimit.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Legacy package, this has been moved to top level types package
 

regclient/types/ref.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Legacy package, this has been moved to the types/ref package
 

regclient/types/types.go

@@ -1,5 +1,5 @@
-//go:build !nolegacy
-// +build !nolegacy
+//go:build legacy
+// +build legacy
 
 // Package types is a legacy package, using the top level types package is recommended
 package types